Ruby Fibonacci custom function

Question

I am trying to write a simple custom function for fibonacci, But i am getting a error:

My code :

class Fibonacci
 def fib(num)
  @num = num.to_i
  series = Array.new
  series[0] = 0
  series[1] = 1

  for i in 0..series[@num]
    series[@num+2] = series[@num] + series[@num+1]
  end
  return series
 end
end

obj = Fibonacci.new
obj.fib(8)

Error :

ruby fibonacci.rb
fibonacci.rb:9:in `fib': bad value for range (ArgumentError)
from fibonacci.rb:19:in `<main>'

Sidenotes: to_i and return are unnecessary here; series = [0,1] can replace lines 2 to 4 in your method definition; use two spaces for indentation throughout; for is not idiomatic Ruby. — Sagar Pandya
– Sagar Pandya, Commented Mar 21, 2017 at 3:54

Navin Peiris · Accepted Answer · 2017-03-21 03:39:19Z

2

You're getting ArgumentError from 0..series[@num], where series[@num] will be nil at that point.

I think you meant to have:

for i in 0..@num
  series[i+2] = series[i] + series[i+1]
end

answered Mar 21, 2017 at 3:39

Navin Peiris

2,6062 gold badges25 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Stefan Over a year ago

To avoid the 2 extra items, you could change the loop to 2.upto(@num) { |i| series[i] = series[i-2] + series[i-1] }

Collectives™ on Stack Overflow

Ruby Fibonacci custom function

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related