Ruby on Rails - wrong number of arguments

Question

def delete_homework
   Homework.all(:conditions => {:teacher => params.require(:teacher) })

   redirect_to :back
end

This is my controller

<div class="row">
  <div class="col s12">
    <div class="card blue-grey lighten-2">
      <div class="card-content white-text">
        <span class="card-title">Delete Homework</span>
        <form action="/welcome/delete_homework">
          <input type="text" name="teacher" placeholder="Teacher Name">
          <input class="btn waves-effect waves-light" type="submit">
        </form>
      </div>
    </div>
  </div>
</div>

This is the HTML side.

When I try this, ruby gives ArgumentError in WelcomeController#delete_homework wrong number of arguments (given 1, expected 0)

what's wrong? please help. Thank you in advance

The all(:conditions =>...) syntax was used in Rails up to version 2.3 and doesn't work anymore in newer versions. Whatever book oder tutorial you found with a code example with that syntax - it is outdated for at least 5 years... — spickermann
– spickermann, Commented Mar 24, 2017 at 7:34
@ashvin Rails.application.routes.draw do get 'welcome/index_array' get 'welcome/index_hash' get 'welcome/index_db' get 'welcome/create_homework' get 'welcome/delete_homework' get 'welcome/index_manage' — Teddy Hwang
– Teddy Hwang, Commented Mar 26, 2017 at 2:24

Mark · Accepted Answer · 2017-03-24 04:24:26Z

2

Change this line:

Homework.all( your_conditions )

to:

Homework.where( your_conditions )

The all method can't take any parameters. It should only be used when you simply want to grab all the records of a given model from the database.

answered Mar 24, 2017 at 4:24

Mark

11.2k6 gold badges34 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sajin · Accepted Answer · 2017-03-24 04:29:23Z

2

Try this

Homework.where(:teacher => params[:teacher])

answered Mar 24, 2017 at 4:29

Sajin

1,6381 gold badge16 silver badges18 bronze badges

2 Comments

Teddy Hwang Over a year ago

Thanks for helping a noob... one more question. What is the code to delete a db with the param teacher?

Sajin Over a year ago

homeworks = Homework.where(:teacher => params[:teacher]) homeworks.delete_all

Collectives™ on Stack Overflow

Ruby on Rails - wrong number of arguments

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related