JavaScript/HTML Code In Variables?

Question

I am designing a monopoly style digital game and want a dice rolling button so i tried this:

<button class="bttnrolldice" onclick="diceRoll()">Roll Dice</button><h1 id="rollresults"></h1> 
<script>
    function diceRoll() {
            var die1 =  math.ceil(math.random() * 7;
            var die2 =  math.ceil(math.random() * 7;
            document.getElementById("rollresults").innerHTML = (die1 + die2); }
</script>

Whenever I run the code, nothing shows up below the button. Can you give me a hand? (It might have something to do with the variables that equal js code, if so tell me how to fix this.)

I just want to Note that you are multiplying a random number between 0 and 1 by 7. Then rounding up. That will give you number 1 through 7 inclusively. You should multiply by 6 to get 1 through 6 (although its possible to still get 0 using random()) — Matthew Ciaramitaro
– Matthew Ciaramitaro, Commented Apr 7, 2017 at 21:27
wait could i do: document.getElementById("rollresults").innerHTML = ((die1 + 1) + (die2 + 1));? — TurnoverEwe0633
– TurnoverEwe0633, Commented Apr 7, 2017 at 21:32
You could use Math.ceil(6*(1 - Math.random())); which would include 1 through 6 but exclude 0 — Matthew Ciaramitaro
– Matthew Ciaramitaro, Commented Apr 7, 2017 at 21:34
Math.random() returns a float between 0 (inclusive) and 1 (exclusive) which is why the subtraction fixes the problem — Matthew Ciaramitaro
– Matthew Ciaramitaro, Commented Apr 7, 2017 at 21:35

Lixus · Accepted Answer · 2017-04-07 21:46:35Z

1

You are missing closing parenthesis on your Math.ceil functions

<button class="bttnrolldice" onclick="diceRoll()">Roll Dice</button><h1 
id="rollresults"></h1> 
<script>
    function diceRoll() {
       var die1 =  Math.ceil(Math.random() * 7);
       var die2 =  Math.ceil(Math.random() * 7);
       document.getElementById("rollresults").innerHTML = (die1 + die2); 
   }
</script>

edited Apr 7, 2017 at 21:46

answered Apr 7, 2017 at 21:20

Lixus

5092 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Matthew Ciaramitaro Over a year ago

I think what he wanted was Math.ceil(Math.random() *7 )

Lixus Over a year ago

@MatthewCiaramitaro Thx did the switch of all Math now it should be correct

TurnoverEwe0633 Over a year ago

Yes omg i use w3 schools.com for reference and I completely missed that part. Thank You!

Tester · Accepted Answer · 2017-04-07 21:22:18Z

1

You are missing a right parentheses on line 4 and line 5.

When running your script in Google Chrome, press [F12] and the error will be described on the Console tab.

answered Apr 7, 2017 at 21:22

Tester

1171 gold badge1 silver badge9 bronze badges

4 Comments

TurnoverEwe0633 Over a year ago

im on a laptop and the button for [F12] is the shortcut for airplane mode... btw im sort of new to js...

TurnoverEwe0633 Over a year ago

especially the math.something part of js

Matthew Ciaramitaro Over a year ago

right click on Chrome in click inspect on the menu and it'll open the inspector. Extremely useful for JS debugging

TurnoverEwe0633 Over a year ago

i see now that you told me

Vaibhav Nigam · Accepted Answer · 2017-04-07 21:19:27Z

0

Inspect element and check browser console for errors.

It should be "Math" instead of "math".
Closing parenthesis are missing in statements where die1 and die2 variables are declared.

answered Apr 7, 2017 at 21:19

Vaibhav Nigam

1,4971 gold badge14 silver badges23 bronze badges

1 Comment

TurnoverEwe0633 Over a year ago

Thank You! This Really Helped!

Collectives™ on Stack Overflow

JavaScript/HTML Code In Variables?

3 Answers 3

3 Comments

4 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

4 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related