java sql insert timestamp java.sql.SQLSyntaxErrorException

Question

i am trying to insert timestamp to my database but i keep getting java.sql.SQLSyntaxErrorException:

here is my code

java.sql.Timestamp sqlDate = new java.sql.Timestamp(new java.util.Date().getTime());
System.out.println(sqlDate);

Here the insertion and connection to DB

Connection conn = DriverManager.getConnection("jdbc:derby://localhost:1598/VotingDB", "app", "app");
    Statement st = conn.createStatement();
    String sql = "INSERT INTO VOTES (CANDIDATE_NAME,VOTER_SSN,TIMESTAMP) "
            + "VALUES ('" + Candidate_Name + "','" + ssn + "'," + TimeStamp + ")";

    st.executeUpdate(sql);
    st.close();
    conn.close();
} catch (SQLException ex) {
    System.out.println("Connection failed adding vote " + ex);
}

Error

2017-04-09 20:10:02.825 Connection failed adding vote java.sql.SQLSyntaxErrorException: Syntax error: Encountered "20" at line 1, column 94.

Graham · Accepted Answer · 2017-09-27 20:38:03Z

2

You should to put your time between '' like this :

"VALUES ('" + Candidate_Name + "','" + ssn + "', ' " + TimeStamp + "')";

But this is not secure enough, you have to use PreparedStatement instead to avoid any SQL Injection.

For example :

String sql = "INSERT INTO VOTES (CANDIDATE_NAME, VOTER_SSN, TIMESTAMP) VALUES (?, ?, ?)";

try (PreparedStatement stm = connection.prepareStatement(sql)) {

    stm.setString(1, Candidate_Name );
    stm.setString(2, ssn );
    stm.setDate(3, TimeStamp);

    stm.executeUpdate();
}

edited Sep 27, 2017 at 20:38

Graham

7,86020 gold badges67 silver badges92 bronze badges

answered Apr 9, 2017 at 18:14

Youcef LAIDANI

60.3k21 gold badges111 silver badges178 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Giorgos Altanis · Accepted Answer · 2017-04-09 18:14:15Z

1

Shouldn't you enclose TimeStamp variable in simple quotes?

String sql = "INSERT INTO VOTES (CANDIDATE_NAME,VOTER_SSN,TIMESTAMP) "
  + "VALUES ('"+Candidate_Name +"','"+ssn +"','"+TimeStamp+"')";

answered Apr 9, 2017 at 18:14

Giorgos Altanis

2,7701 gold badge15 silver badges14 bronze badges

Collectives™ on Stack Overflow

java sql insert timestamp java.sql.SQLSyntaxErrorException

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related