Syntax error when defining function

Question

I've got a syntax error when defining this function.

def questionfilehandler("filename.txt"):
    with open("filename.txt", "r") as file:
        print(file.read)
        return input()
        file.close()

I've looked up the syntax, and it all appears to be correct.
This is the error message I got
And this is the code with the error highlighted by IDLE.

Thanks to everyone who reads and tries to answer this. Your time is greatly appreciated =).

Is the code you show a direct copy-paste of the actual code? With the indentation as shown? — Some programmer dude
– Some programmer dude, Commented Apr 12, 2017 at 17:38
Sorry, that was a mistake in writing it on the website. The indents are correct in the real program. I've fixed them now. — Bob14
– Bob14, Commented Apr 12, 2017 at 17:40
Your parameter for the function can't be written as a string. — Matthias
– Matthias, Commented Apr 12, 2017 at 17:41
One other thing to know is that when using the context handler with open(my_file ... you don't need to call my_file.close() at the end. It's automatically handled by the with statement! — Christopher Apple
– Christopher Apple, Commented Apr 12, 2017 at 17:42

JacobIRR · Accepted Answer · 2017-04-12 17:43:22Z

9

Assuming your indentation gets fixed, which is obvious... you cannot call a string directly as a function argument. You need a variable:

def questionfilehandler(filename):
    with open(filename, "r") as file:
        print(file.read())
        return input()
        # file.close() - not needed

Then... you can call the function with a string as its argument:

questionfilehandler("filename.txt")

edited Apr 12, 2017 at 17:43

answered Apr 12, 2017 at 17:39

JacobIRR

9,0468 gold badges47 silver badges73 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

JacobIRR Over a year ago

@ZaurNasibov - fixed, and commented out file.close()

JacobIRR Over a year ago

@Bob14 - please consider accepting this answer if this works for you.

Raj Damani · Accepted Answer · 2017-04-12 17:56:06Z

0

def questionfilehandler(filename = "data.txt"): # filename has default value so it will take your input if you provide with function call.
    with open(filename) as filedata:
        # print(file.read()) # no need for this method as all work done by "open()".
        for data in filedata:
            print data

questionfilehandler() # You can pass file name if you want to else keep the default.

No need of filename.close() as "with" operator handles it automatically.

answered Apr 12, 2017 at 17:56

Raj Damani

8021 gold badge8 silver badges19 bronze badges

Collectives™ on Stack Overflow

Syntax error when defining function

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related