PHP Append filenames to array

Question

I am trying to append filenames to an array in PHP. I have code which reads filenames from a directory "songs" on a server. I simply want each of these filenames to be added to an array. How could I do this?

Here is my PHP.

$target = "songs/"; 
$items = array();
if ($handle = opendir($target)) {
    while (false !== ($entry = readdir($handle))) {
        if ($entry != "." && $entry != "..") {
            foreach($song as $entry) {
                $items[] = $entry; 
            }

            //echo $items;
            echo $entry."\n";
        }
    }
    closedir($handle);
}

What isn't working with the code you have? What does $items look like after the while? — Sloan Thrasher
– Sloan Thrasher, Commented Apr 14, 2017 at 21:13
When I echo $items it returns "ArrayArrayArrayArray......" Stuck in loop. @SloanThrasher — gsanchez
– gsanchez, Commented Apr 14, 2017 at 21:17
You're using the same variable $entry for the filename and in foreach ($song as $entry). So after the loop, $entry contains the last element of $song, not the filename. — Barmar
– Barmar, Commented Apr 14, 2017 at 21:19
What does the database code at the top have to do with this? — Barmar
– Barmar, Commented Apr 14, 2017 at 21:19

Barmar · Accepted Answer · 2017-04-14 21:23:59Z

1

You're using the same variable in the foreach loop as you're using to hold the filename from readdir(). So when you do $items[] = $entry; you're adding the iteration variable to the array, not the filename. There doesn't seem to be any reason to add the filename to the array inside the loop, and you should avoid reusing variables like that, it just causes confusion.

$items = array();
if ($handle = opendir($target)) {
    while ($entry = readdir($handle)) {
        if ($entry != "." && $entry != "..") {
            $items[] = $entry;
            foreach($song as $s) {
                // do something with $s
            }

            //echo $items;
            echo $entry."\n";
        }
    }
    closedir($handle);
}

answered Apr 14, 2017 at 21:23

Barmar

789k57 gold badges554 silver badges669 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

gsanchez Over a year ago

It seems I am still having trouble. I want each $entry to be appended to the array. @Barmar

Barmar Over a year ago

This does append each $entry to the array, except for . and ...

Collectives™ on Stack Overflow

PHP Append filenames to array

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related