Which is faster when adding variables to an array?
- $variable[] = $newValue;
- array_push($variable,$newValue);
and please mention the difference between the two if any.
-
11Doesn't matter. Both are blazing fast and the difference is negligible. Stop overoptimising your code. Focus on real problems.Michał Niedźwiedzki– Michał Niedźwiedzki2010-12-03 10:27:07 +00:00Commented Dec 3, 2010 at 10:27
-
What happenned when you tested it?symcbean– symcbean2010-12-03 10:48:00 +00:00Commented Dec 3, 2010 at 10:48
-
I've had instances where array_push didn't work for multidimensional array but the direct assignment did. So, unless you are working with a very large array I say go with whichever you feel comfortable with (or works) !thethakuri– thethakuri2015-07-06 14:04:15 +00:00Commented Jul 6, 2015 at 14:04
Add a comment
|
2 Answers
http://www.php.net/manual/en/function.array-push.php#53289
Empy bracket doesn't check if a variable is an array first as array_push does. If array_push finds that a variable isn't an array it prints a Warning message if E_ALL error reporting is on.
So array_push is safer than [], until further this is changed by the PHP developers.
$variable[] seems to be a lot faster:
http://www.php.net/manual/en/function.array-push.php#83388
However if you're adding multiple values per iteration array_push() is faster:
http://www.php.net/manual/en/function.array-push.php#84959
But please remember that pre-optimization is the root of all evil. Use whatever you feel more comfortable with, and when you have a performance issue, use a profiler and do some benchmarking.
Comments
Stop doing weird things and take profiler to get real bottleneck.
ps: there is no difference.
pps: here is typical algo:
- Does the application speed satisfy you? If no - step 2, if yes - step 6
- Take the profiler
- Find the slowest part
- Optimize it so it become faster
- Go to step 1
- Get some beer
Comments
