Reduce javascript code

Question

I have two functions in my angular project, one is aceitaProposta that does this:

aceitaProposta() {
    this.aceita();
    // some other code
}

and I have recusaProposta:

recusaProposta() {
    this.recusa();
    // some other code
}

Now, the only difference between this.recusa and this.aceita is that the first one increments a property and the second one decrement it. I want to know if there's a way that I can transform these two functions into one function only using something like if to identify if its decrementing or incrementing. This way I would call the same function in both aceitaProposta and recusaProposta. Example:

aceitaProposta() {
   this.incrementDecrement();
    // some other code
}

recusaProposta() {
    this.incrementDecrement();
    // some other code
}

Sure, you can pass a boolean to the function to indicate whether the value should be incremented or decremented. — Felix Kling
– Felix Kling, Commented Apr 25, 2017 at 16:42
Why do you need one function to do two different things? It's better to keep them separate instead of adding control flow to something that's supposed to be simple. — Max Paymar
– Max Paymar, Commented Apr 25, 2017 at 16:49

Jordan Soltman · Accepted Answer · 2017-04-25 16:55:28Z

2

Should be pretty easy.

function incrementDecrement(inc: boolean)
{
    inc ? this.prop++ : this.prop--;
}

edited Apr 25, 2017 at 16:55

answered Apr 25, 2017 at 16:44

Jordan Soltman

3,95322 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Bergi Over a year ago

Might as well be this.prop += inc - !inc; For clarity, use an if/else statement.

zigzag Over a year ago

They've tagged the question with angular, so I think it's good to show a TypeScript answer here too.

zigzag · Accepted Answer · 2017-04-25 16:50:02Z

1

@KingFelix has it. Just pass a boolean.

incrementDecrement(shouldIncrement: boolean) {
  shouldIncrement ? value++ : value--;
}

aceitaProposta() {
    this.incrementDecrement(true);
}

recusaProposta() {
    this.incrementDecrement(false);
}

answered Apr 25, 2017 at 16:50

zigzag

3212 silver badges13 bronze badges

1 Comment

Renê Silva Lima Over a year ago

oh, that's it. Thank you very much

rayepps · Accepted Answer · 2017-04-25 16:57:28Z

1

Another way to do this uses ES6 and more 'functional' code. Make the parameter a function instead of a boolean. Then make the change in the function you pass.

update(alteration) {
    x = alteration(x);
}

aceitaProposta() {
    this.update((x) => x - 1);
}

recusalProposta() {
    this.update((x) => x + 1);
}

Without ES6 its a little ugly but you would just add in the anonymous function declarations.

answered Apr 25, 2017 at 16:57

rayepps

2,0921 gold badge14 silver badges23 bronze badges

Collectives™ on Stack Overflow

Reduce javascript code

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related