Passing a String Array Between Java Classes Android App

Question

I am writing an Android app where I need to pass a string array between two classes. The string initializes fine and I can output the contents of the string fine in the one class but as I try to pass it to another class I get a Null Pointer Exception error. The following is the stripped down version of my code:

accelerometer.java:

    public class accelerometer extends Service {

 public String movement[];

 public void onCreate() {

  movement = new String[1000000];

 }

 public void updatearray() {
  movement[arraypos]=getCurrentTimeString();
  //Toast.makeText(this, movement[arraypos] , Toast.LENGTH_SHORT).show(); //this correctly displays each position in the array every time it updates so I know the array is working correctly in this file
  arraypos+=1;
 }

 public String[] getmovement(){
  return movement;
 }
    }

wakeupalarm.java:

    public class wakeupalarm extends Activity {

 private TextView herestext_;

 public void onCreate(Bundle savedInstanceState) {
  super.onCreate(savedInstanceState);
  setContentView(R.layout.wakeup);

  herestext_ = (TextView) findViewById(R.id.TextView01);

  accelerometer accelerometercall = new accelerometer();

  String movearray[] = accelerometercall.getmovement();

  herestext_.setText(movearray[2]);
  }

    }

I have a feeling I'm missing something very simple but any help would be greatly appreciated!

Thanks,

Scott

EboMike · Accepted Answer · 2010-12-06 03:40:38Z

1

You're creating a new accelerometer class, which is completely uninitialized since there is no constructor, then you access its member. Of course it'll be null.

Not sure how your two classes are related, but if the activity is called by the service, then you need to pass the string through the intent (through an extra, for example).

Side note: Class names should always start with a capital letter. Method/variable names should have camel case, i.e. "updateArray". Also, you can format your code here by selecting it and pressing CTRL+K.

answered Dec 6, 2010 at 3:40

EboMike

78k15 gold badges172 silver badges171 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

vy32 · Accepted Answer · 2010-12-06 03:41:04Z

0

Your first problem, I think, is that you are creating an array with a million slots in it. Do you really mean to be doing that? It's going to take a lot of memory---quite possibly more than is available. You should instead look to having a Vector of Strings that you extend as necessary.

answered Dec 6, 2010 at 3:41

vy32

30k39 gold badges139 silver badges264 bronze badges

2 Comments

Asaph Over a year ago

I doubt the million slot array is causing a NullPointerException to be thrown. If the OP was running out of memory you would see an OutOfMemoryException or something like that. Although, I do agree that it's probably an unnecessarily large array.

vy32 Over a year ago

Yeah, I wasn't answering the question, so much as complaining about the programming style.

Collectives™ on Stack Overflow

Passing a String Array Between Java Classes Android App

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related