Sorting an array of object

Question

I wish to sort an array of medals. My first sort returns an array sorted according to the gold medals. I then wish to range those which are having the same gold but silver medals are different (same for bronze). I use the following codes that actually makes me run out of memory. This is my code:

static sort(data) {
    let sorted = data.sort((a, b) => b.medal.gold - a.medal.gold);
    let next, temp, current;
    for (let i = 0; i < sorted.length; i++) {
        current = sorted[i].medal;
        if (sorted[i+1]) next = sorted[i+1].medal;
        if (next) {
            if (current.gold === next.gold) {
                if (current.silver < next.silver) {
                    temp = sorted[i+1];
                    sorted[i+1] = sorted[i];
                    sorted[i] = temp;
                }
                else if (current.silver === next.silver) {
                    if (current.bronze < next.bronze) {
                        temp = sorted[i+1];
                        sorted[i+1] = sorted[i];
                        sorted[i] = temp;
                    }
                }
            }
        }
    }
    return sorted;
}

Please update your array data into your question for more detailed. — Thanh Nguyen
– Thanh Nguyen, Commented Apr 27, 2017 at 9:29
an example would be: ` [{ id: 1, medals: {gold: 2, silver: 1, bronze: 1}}, { id: 2, medals: {gold: 2, silver: 4, bronze: 1} }, { id: 3, medals: {gold: 5, silver: 1, bronze: 4} } ]` — franckstifler
– franckstifler, Commented Apr 27, 2017 at 9:47

trincot · Accepted Answer · 2017-04-27 09:36:38Z

3

You'll want to improve your compare function so it takes care of that requirement:

data.sort((a, b) => (b.medal.gold - a.medal.gold) 
                 || (b.medal.silver - a.medal.silver) 
                 || (b.medal.bronze - a.medal.bronze) )

And then you don't need the (endless) for loop at all.

answered Apr 27, 2017 at 9:36

trincot

357k38 gold badges282 silver badges338 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

djvuk · Accepted Answer · 2017-04-27 10:13:56Z

2

You have to set next to null somewhere, because it keeps the value from the previous iteration and the if(next) is always true. Afterwards the function will always create one more element and add it in the array (sorted[i+1] = sorted[i]) until you run out of memory.

Here is a working example:

var rawData = 
    [{ id: 1, medal: {gold: 2, silver: 1, bronze: 1}}, 
     { id: 2, medal: {gold: 2, silver: 1, bronze: 2} }, 
     { id: 3, medal: {gold: 5, silver: 1, bronze: 4} } ];

function sortData(data) {
    let sorted = data.sort((a, b) => b.medal.gold - a.medal.gold);
    let next, temp, current;
    for (let i = 0; i < sorted.length; i++) {
        next = undefined;
        current = sorted[i].medal;
        if (sorted[i+1]) next = sorted[i+1].medal;
        if (next) {
            if (current.gold === next.gold) {
                if (current.silver < next.silver) {
                    temp = sorted[i+1];
                    sorted[i+1] = sorted[i];
                    sorted[i] = temp;
                }
                else if (current.silver === next.silver) {
                    if (current.bronze < next.bronze) {
                        temp = sorted[i+1];
                        sorted[i+1] = sorted[i];
                        sorted[i] = temp;
                    }
                }
            }
        }
    }
    return sorted;
};

console.log(sortData(rawData))

Please note that in the function you are using medal instead of medals as the data you have provided in one of your comments.

edited Apr 27, 2017 at 10:13

answered Apr 27, 2017 at 9:35

djvuk

3703 silver badges15 bronze badges

3 Comments

trincot Over a year ago

Indeed. Well spotted!

franckstifler Over a year ago

Great. But i am also interested in why the code above does not work.

trincot Over a year ago

Eh... it is explained.

Collectives™ on Stack Overflow

Sorting an array of object

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related