angularjs dependency injection $scope not working

Question

I am learning AngularJS DI concept, Can anyone tell me why below code not working?

<script type="text/javascript">

        var myApp = angular.module('myApp',[])

    var myController = myApp.controller('MyController', function(a){
        a.name = 'william'
        console.log(a.name)
    })

    myController.$inject = ['$scope']

    </script>

Iam getting an error as: https://docs.angularjs.org/error/$injector/unpr?p0=aProvider%20%3C-%20a

In above code, in place of 'a', if replaced with '$scope', it definitely works. As far as I understand, angular should inject $scope into 'a' parameter, right?

JB Nizet · Accepted Answer · 2017-04-30 16:29:00Z

1

$inject must be defined on the controller, not on the module:

var ctrl = function(a) { ... };
ctrl.$inject = ['$scope'];
myApp.controller('MyController', ctrl);

But I strongy suggest you

use $scope for your variable rather than a
let ng-annotate transform the code to minifiable code automatically.

edited Apr 30, 2017 at 16:29

answered Apr 30, 2017 at 16:20

JB Nizet

694k94 gold badges1.3k silver badges1.3k bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

John Over a year ago

I updated my code, still not injecting..whats the problem? BTW, when should I use ng-annotate?

JB Nizet Over a year ago

Sorry. Mistake on my side. See the edited answer. plnkr.co/edit/DKUS15Qn4XwvjBmXfIus?p=preview

John Over a year ago

In your code, you have created some function and then at line 7, you have declared as myController.$inject = ['$scope'] , but why does it not give an error at this line ? The reason i asked because $inject belongs to angularjs, right? myController is just a function, so how does a normal function can call $inject directly?

JB Nizet Over a year ago

A function is also an object in JavaScript, and can thus have arbitrary, dynamically assigned attributes, like $inject.

John Over a year ago

okay fine. But I do not understand one thing, Why does my code not working? I mean why injecting getting failed in my case..whats the differnce between your code and mine? you first created function outside and then used it inside .controller, right? Could you please explain briefly?

|

Matej Marconak · Accepted Answer · 2017-04-30 16:26:21Z

0

$inject should be on controller function:

    var myApp = angular.module('myApp',[])

    myApp.controller('MyController', function myController(a){
        a.name = 'william'
        console.log(a.name)
    })

    myController.$inject = ['$scope']

answered Apr 30, 2017 at 16:26

Matej Marconak

1,4133 gold badges21 silver badges27 bronze badges

Collectives™ on Stack Overflow

angularjs dependency injection $scope not working

2 Answers 2

7 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related