PHP: array search when array doesn't start on zero

Question

I'm trying to find a key in an array that doesn't start with zero.

This is my not so elegant solution:

private $imagetypes = [
    1 => [
        'name' => 'banner_big',
        'path' => 'campaigns/big/'
    ],
    2 => [
        'name' => 'banner_small',
        'path' => 'campaigns/small/'
    ],
// ...

If i use $key = array_search('banner_big', array_column($this->imagetypes, 'name')); the result is 0

I came up with this solution but I feel like I needlessly complicated the code:

 /**
 * @param string $name
 * @return int
 */
public function getImagetypeFromName($name)
{
    $keys = array_keys($this->imagetypes);
    $key = array_search($name, array_column($this->imagetypes, 'name'));
    if ($key !== false && array_key_exists($key, $keys)) {
        return $keys[$key];
    }
    return -1;
}

Is there a better solution then this.

I can't change the keys in.

splash58 · Accepted Answer · 2017-05-11 14:14:00Z

2

Just save indexes

$key = array_search('banner_big',
                     array_combine(array_keys($imagetypes),
                                    array_column($imagetypes, 'name')));

demo on eval.in

answered May 11, 2017 at 14:14

splash58

26.2k3 gold badges25 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Luke · Accepted Answer · 2017-05-11 14:20:17Z

0

The problem is array_column will return a new array (without the existing indexes)

So in your example.

$key = array_search('banner_big', array_column($this->imagetypes, 'name'));

var_dump($key);

//$key is 0 as 0 is the key for the first element in the array returned by array_column.

You can mitigate against this by creating a new array with the existing keys.

answered May 11, 2017 at 14:20

Luke

3,5916 gold badges42 silver badges64 bronze badges

Comments

sidyll · Accepted Answer · 2017-05-11 14:24:53Z

0

That's because array_column() generates another array (starting at index zero), as you may have imagined. An idea to solve this would be to transform the array with array_map(), reducing it to key and image name (which is what you're searching for). The keys will be the same, and this can be achieved with a simple callback:

function($e) {
    return $e['name'];
}

So, a full implementation for your case:

public function
getImagetypeFromName($name)
{
    $key = array_search($name, array_map(function($e) {
        return $e['name'];
    }, $this->imagetypes));

    return $key ?: -1;
}

answered May 11, 2017 at 14:24

sidyll

59.5k14 gold badges115 silver badges155 bronze badges

Collectives™ on Stack Overflow

PHP: array search when array doesn't start on zero

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related