batch file reading variable from for loop

Question

I have a small batch script and wondering why is it working like this. The snippets shows a for loop which should look for Rf-Stick1.conf and find the string "type". Futhermore it should write the following value into "TYPE".

It works when i use "echo !TYPE!", but the if statement is not working. Someone knows the problem?

for /f "tokens=2 delims=: " %%a in ('type "Configs\Rf-Stick1.conf" ^| findstr /ir "^type" 2^>nul') DO set "TYPE=%%a"        

echo !TYPE!
if !TYPE! EQU "RF" echo rf

@MCND's answer is probably what you need, but also use something like echo ::!TYPE!:: whenever debugging values so you can see if there are leading/trailing spaces etc. that might be causing problems. — TripeHound
– TripeHound, Commented May 12, 2017 at 10:49
The if statement takes the quotation marks literally and includes them in the comparison; hence you must provide them on both sides of the comparison operator: if "!TYPE!" EQU "RF" echo rf — aschipfl
– aschipfl, Commented May 12, 2017 at 11:27

MC ND · Accepted Answer · 2017-05-12 10:36:56Z

2

If the variable TYPE contains the value RF, then the command

if !TYPE! EQU "RF" echo rf

is parsed and converted into

if RF EQU "RF" echo rf

As you can see, you are comparing a string without quotes against a string with quotes, so, they don't match. Try with

if "!TYPE!" EQU "RF" echo rf

answered May 12, 2017 at 10:36

MC ND

71.1k8 gold badges95 silver badges136 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

sziraqui · Accepted Answer · 2017-05-12 10:14:47Z

0

Probably because if !TYPE! is interpreted as if not TYPE! You need to change your if condition so that the effective condition is what you want.

answered May 12, 2017 at 10:14

sziraqui

6,1523 gold badges31 silver badges37 bronze badges

2 Comments

xy36 Over a year ago

hmm, well, but if i use %TYPE% instead as i usually do, it doesnt work. Any suggestion?

sziraqui Over a year ago

What's the output of echo %TYPE%

Collectives™ on Stack Overflow

batch file reading variable from for loop

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related