Javascript ReferenceError: function is not defined but it is

Question

I have checked the code, but I can't find anything wrong.

<!-- language: lang-html -->

<div class="modal fade" id="loginModal" role="dialog">
    <div class="modal-dialog">
        <!-- Modal content-->
        <div class="modal-content">
            <div id="loginHeader" class="modal-header">
                <h4 class="modal-title">Oops, something not right.</h4>
            </div>
            <div id="loginContent" class="modal-body" runat="server">
            </div>
            <div id="loginButton" class="modal-footer">
                <button type="button" class="btn btn-warning" data-dismiss="modal">OK</button>
            </div>
        </div>
    </div>
    <button type="button" style="display: none;" id="btnShowLoginModal" data-toggle="modal" data-target="#loginModal">
    </button>
</div>
<script src="../Scripts/javascripts/jquery.js"></script>
<script src="../Scripts/javascripts/bootstrap.min.js"></script>
<script type="text/javascript">
    function ShowLoginDialog() {
        $("#btnShowLoginModal").click();
    }
</script>

The function is called from code behind on OnClick Event. Still no clue which part is wrong.

protected void Button1_Click(object sender, EventArgs e)
{
    string result = ValidateLogin(Username.Value, Password.Value);

    if(result == MessageConstants.MessageSuccess)
    {
        Response.Redirect("~/Webpages/Character.aspx");
    }
    else if(result == MessageConstants.MessageFail)
    {
        ScriptManager.RegisterStartupScript(this, this.GetType(), Guid.NewGuid().ToString(), "ShowLoginDialog()", true);
    }
    else
    {
        ScriptManager.RegisterStartupScript(this, this.GetType(), Guid.NewGuid().ToString(), "ShowLoginDialog()", true);

    }
}

Error from Element Inspector

Where is it being called from? Please provide a minimal reproducible example — charlietfl
– charlietfl, Commented May 13, 2017 at 18:47
Move the inline script (containing the function) before any other script tags, probably in the head tag. — trincot
– trincot, Commented May 13, 2017 at 19:02

Kevin Collins · Accepted Answer · 2017-05-13 19:27:44Z

2

RegisterStartupScript() emits the script block at the end of the Web Form (right before the </form> tag). source

But your modal code, and the ShowLoginDialog function are defined after that. Try moving that </form> tag to the end, after the modal stuff.

answered May 13, 2017 at 19:27

Kevin Collins

1,4361 gold badge10 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

BernardWong Over a year ago

thank you so much! it actually works when i move the script into the <form> tag.

flowest · Accepted Answer · 2017-05-13 18:51:12Z

0

Put your code in the document.ready() function:

$( document ).ready(function() {
    function ShowLoginDialog() {
        $("#btnShowLoginModal").click();
    }
});

answered May 13, 2017 at 18:51

flowest

1833 silver badges11 bronze badges

3 Comments

Sagar Jajoriya Over a year ago

When you call that function, on page load or on any event ?

BernardWong Over a year ago

@SKJajoriya its actually OnClick event called that function

Lennholm Over a year ago

This will only make the issue worse because ShowLoginDialog will not be available on the global scope

Lennholm · Accepted Answer · 2017-05-13 19:26:34Z

0

Move

<script src="../Scripts/javascripts/jquery.js"></script>
<script src="../Scripts/javascripts/bootstrap.min.js"></script>
<script type="text/javascript">
    function ShowLoginDialog() {
        $("#btnShowLoginModal").click();
    }
</script>

into the head block. Then you need to change the ShowLoginDialog function so that it looks like this:

function ShowLoginDialog() {
    $(function() {
        $("#btnShowLoginModal").click();
    });
}

answered May 13, 2017 at 19:26

Lennholm

7,5301 gold badge23 silver badges32 bronze badges

Collectives™ on Stack Overflow

Javascript ReferenceError: function is not defined but it is

3 Answers 3

1 Comment

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related