SQL query not returning array

Question

Working on getting a page to build off of an array that is returned from a DB to post a story, not sure what it is not working. The page URL looks like this: https://ohcrap.ninja/games/ps4/article.php?id=1

Here is the code that should be generating the content:

        <?php

        $id = $_GET['id'];
        $query = mysqli_query($con,'SELECT * FROM `PS4` WHERE `id` =' .$id) or die(mysqli_error($con));
        while ($row = mysqli_fetch_array($query));
        // Echo page content
                echo "<div class='col s12 m12 l12'>";
                echo "<div class='card small grey darken-3'>";
                echo "<div class='card-stacked'>";
                echo "<div class='card-content'>";
                echo "$id";
                echo "<span class='card-title'>" . $row['title'] . "</span>";
                echo "<hr color='black'>";
                echo "<P>By:<i> " . $row['author'] . "</i></P>";
                echo "<P>Published: " . $row['published'] . "</P>"; 
                echo "<br>";
                echo "<P class='truncate'>" . $row['story'] . "</P>";
                echo "</div>";
                echo "</div>";
                echo "</div>";
                echo "</div>";
    ?>

Little Bobby says your script is at risk for SQL Injection Attacks. Learn about prepared statements for MySQLi. Even escaping the string is not safe! — Jay Blanchard
– Jay Blanchard, Commented May 17, 2017 at 21:47
Thanks for the heads up, I will take a look into it. I appreciate that! — Rob Hood
– Rob Hood, Commented May 17, 2017 at 21:50

rickdenhaan · Accepted Answer · 2017-05-17 21:47:19Z

1

Your while loop is not doing anything useful, because you're immediately ending it with that ;.

while ($row = mysqli_fetch_array($query)) {
    // all those echoes
}

answered May 17, 2017 at 21:47

rickdenhaan

11.4k32 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Rob Hood Over a year ago

Thanks that got it, I am not sure why I did not catch that one. I will accept the answer once it lets me!

Don't Panic Over a year ago

I think it's also worth explicitly noting that the braces are required to do all those echoes even after the stray semicolon is removed, rather than just looping echo "<div class='col s12 m12 l12'>";

Collectives™ on Stack Overflow

SQL query not returning array

1 Answer 1

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related