How to send php variable onclick of button to javascript function as parameter

Question

I am using codeigniter 3. Below is the code of the view page, where data inside the $row->poll_question; is coming from the database. Thus, the different values coming inside this variable are echoed on a page called voting.php. And just beside this variable, there is a button called View Poll. Now, on clicking this button I want to pass the data of this php variable to javascript section. And simply alert and check in javascript. Please help. I have pasted the code I tried.

voting.php

<h3 class="val" id="val" style="color:rgb(158, 158, 158);font-family: 
arial;margin-top: 2%;" ><?php echo $row->poll_question; ?></h3>
</td>

<td>

<a class="btn btn-lg btn-primary view_button" id="view_button" 
 style="margin-left: 18%;padding:10%;border-radius: 10px;" 
 onclick="fetch_val(<?php echo $row->poll_question ?>)">View Poll</a>

Javascript

function fetch_val(val)
{
     alert(val);
}

Super User · Accepted Answer · 2017-05-23 11:35:41Z

1

You have forgot to add quote on '<?php echo $row->poll_question ?>'. Check updated code below

<h3 class="val" id="val" style="color:rgb(158, 158, 158);font-family: 
arial;margin-top: 2%;" ><?php echo $row->poll_question; ?></h3>
</td>

<td>

<a class="btn btn-lg btn-primary view_button" id="view_button" 
 style="margin-left: 18%;padding:10%;border-radius: 10px;" 
 onclick="fetch_val('<?php echo $row->poll_question ?>')">View Poll</a>

answered May 23, 2017 at 11:35

Super User

9,6623 gold badges34 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

mickmackusa · Accepted Answer · 2019-08-10 11:30:12Z

1

I don't recommend the redundant storage of the string.

You already have the value in your id'ed <h3> tag. Just use that.

Further advice move all stylings to an external stylesheet and use a javascript listener on your #view_button.

You could stay with an inline function call:

<h3 class="val" id="val"><?php echo $row->poll_question; ?></h3>

<a class="btn btn-lg btn-primary view_button" id="view_button" 
   onclick="fetch_val(document.getElementById('val').innerHTML);">View Poll</a>

Or trigger fetch_val() via a listener written in your javascript (this is the cleaner / more professional way):

document.getElementById('view_button').onclick = function() {
    alert(document.getElementById('val').innerHTML);
}

About writing a pure javascript onclick handler: https://stackoverflow.com/a/17633164/2943403

Assigning a custom function to an event: https://stackoverflow.com/a/24665785/2943403

Using either of my above techniques will remove the possibility of quoting issues caused by questions like What is your mother's maiden name?.

answered Aug 10, 2019 at 11:30

mickmackusa♦

49.2k13 gold badges98 silver badges165 bronze badges

1 Comment

Unnati Over a year ago

Thank you so much @mickmackusa . I will definitely keep this in mind too.

Collectives™ on Stack Overflow

How to send php variable onclick of button to javascript function as parameter

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related