PHP Send data back to AJAX

Question

I'm trying to get data from my database using ajax and php, but whenever I try to get it I get an error with ajax. Here is my code:

HTML

Here is my code where I request the php file.

<body>
    <div id="wrapper">
        <h2>Coffe Shop</h2>
        <p class="bold">Drink orders:</p>

        <ul class="orders">
        </ul>

        <p class="bold">Add an order:</p>
        <p>Drink: <input type="text" id="name"/><input type="submit" id="submit"/></p>

        <button id="refresh">CLICK ME</button>
    </div>

    <script>
        $(function (){
            $("#refresh").on("click", function() {
               $.ajax({
                type: "GET",
                url: "data.php",
                dataType: "json",
                success: function(names){
                    $.each(names, function(name){
                        alert(name);
                    });
                },
                error: function(){
                    alert("error");
                }
           });
        }); 
            });

    </script>
</body>

PHP

Here is my PHP file

<?php

$conn = mysqli_connect("localhost:8080", "root", "", "test1")
    or die("Error with connection");


$sql = "SELECT ime FROM users;";

$result = mysqli_query($conn, $sql);

$row = mysqli_fetch_array($result);
$names = array();

while($row){
    $name = array(
        "name"=> $row['ime']
    );

$names[] = $name;
}

echo json_encode($names);

What is the error?

Alex K.
– Alex K.

2017-05-25 13:46:40 +00:00
Commented May 25, 2017 at 13:46 — Alex K.
– Alex K., Commented May 25, 2017 at 13:46

Barmar · Accepted Answer · 2017-05-25 13:55:55Z

2

You have an infinite loop in your PHP. You're just fetching one row, and then looping over that same row. Since you never change $row in the loop, it never ends. It should be:

while ($row = mysqli_fetch_assoc($result)) {
    $name = array('name' => $row['ime']);
    $names[] = $name;
}

Once you fix that, the JSON you'll be sending will look like:

[{"name": "Some name"}, {"name": "Another name"}, {"name": "Fred"}]

In your Javascript, you're not accessing the name property. Change

alert(name);

to:

alert(name.name);

Or you could change the PHP so it just sends an array of strings instead of objects:

while ($row = mysqli_fetch_assoc($result)) {
    $names[] = $row['ime'];
}

answered May 25, 2017 at 13:55

Barmar

789k57 gold badges555 silver badges669 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

PHP Send data back to AJAX

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related