Why function file returns empty array?

Question

Done
<?php
    define('FILE_NAME', 'list.dat');
    define('MAX_BREAK', 30);

    function write($file, $ip, $time)
    {
        fwrite($file, $ip . '|' . $time . "\n");
    }

    $new_ip = /*$REMOTE_ADDR*/ $_SERVER['REMOTE_ADDR'];
    $file = fopen(FILE_NAME, 'w+');
    flock($file, LOCK_EX | LOCK_SH);

    $array = file(FILE_NAME, FILE_IGNORE_NEW_LINES);
    $contains = false;
    foreach ($array as $record)
    {
        $values = explode('|', $record);
        $ip = $values[0];
        $time = $values[1];
        if ($ip == $new_ip)
        {
            $time = time();
            $contains = true;
        }
        if (time() - $time < MAX_BREAK)
            write($file, $ip, $time);
    }
    if (!$contains)
        write($file, $new_ip, time());

    flock($file, LOCK_UN);
    fclose($file);
?>

$array is empty, but it shouldn't because file contains one line. Any ideas why?

ajreal · Accepted Answer · 2010-12-11 22:29:18Z

2

Because list.dat is empty.

fopen with w+

'w+' Open for reading and writing; place the file pointer at the beginning of the file and truncate the file to zero length. If the file does not exist, attempt to create it.

answered Dec 11, 2010 at 22:29

ajreal

47.4k11 gold badges97 silver badges119 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

bmb · Accepted Answer · 2010-12-11 22:27:41Z

1

If the file command is returning false, it means file() failed. I think it might be failing because you already have it locked with your flock() call. The file() function does not need to be preceded by an fopen().

answered Dec 11, 2010 at 22:27

bmb

6,2983 gold badges41 silver badges60 bronze badges

1 Comment

BoltClock Over a year ago

He is calling fopen() to write to the file.

svens · Accepted Answer · 2010-12-11 22:28:45Z

1

Using flock() you aquire an exclusive lock on the file and after that you want to read it. That doesn't work. A shared lock will probably be enough (no one can alter the file while it's locked).

flock($file, LOCK_EX | LOCK_SH);

becomes

flock($file, LOCK_SH);

answered Dec 11, 2010 at 22:28

svens

11.6k6 gold badges41 silver badges55 bronze badges

Collectives™ on Stack Overflow

Why function file returns empty array?

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related