For loop not finding max value of array (Javascript)

Question

My function 'extremeValue' takes 2 parameters, an array and a string "Maximum" or "Minimum", and depending on that string it returns the maximum or minimum value of the array. I used an example array 'values' to pass through the function and while it works out the minimum just fine, the maximum comes out to be the last value of the array. What's wrong with my code?

var values = [4, 3, 6, 12, 1, 3, 7];
            
function extremeValue(array, maxmin) {
	if (maxmin === "Maximum") {
		var max = array[0];
		for (var i = 1; i < array.length; i++) {
			if (array[i] > array[i-1]) {
				max = array[i];
			}
		}
		return max;
	}
	else if (maxmin === "Minimum") {
		var min = array[0];
		for (var j = 1; j < array.length; j++) {
			if (array[j] < array[j-1]) {
				min = array[j];
			}
		}
		return min;
	}
}
            
console.log(extremeValue(values, "Maximum")); 
console.log(extremeValue(values, "Minimum"));

Jared Smith · Accepted Answer · 2017-05-28 04:04:11Z

4

Change the checking with maximum value.

if (maxmin === "Maximum") {
    var max = array[0];
    for (var i = 1; i < array.length; i++) {
        if (array[i] > max) { //not just before 'array[i-1]'
            max = array[i];
        }
    }
    return max;
}

OR

Simply Use

Math.max.apply( Math, values );

to find Maximum from values.and

Math.min.apply( Math, values );

for minimum values.

edited May 28, 2017 at 4:04

Jared Smith

22.3k5 gold badges50 silver badges98 bronze badges

answered May 28, 2017 at 3:48

Adharsh M

2,7903 gold badges23 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Adharsh M Over a year ago

@jared-smith Thanks for your Edit.

Jared Smith Over a year ago

No problem. Good answer.

Mohammad Hamedani · Accepted Answer · 2017-05-28 03:42:41Z

1

In each loop you must compare an item with maximum (or minimum) value, not before item:

var values = [4, 3, 6, 12, 1, 3, 7];

function extremeValue(array, maxmin) {
    if (maxmin === "Maximum") {
        var max = array[0];
        for (var i = 1; i < array.length; i++) {
            if (array[i] > max) {
                max = array[i];
            }
        }
        return max;
    }
    else if (maxmin === "Minimum") {
        var min = array[0];
        for (var j = 1; j < array.length; j++) {
            if (array[j] < min) {
                min = array[j];
            }
        }
        return min;
    }
}

console.log(extremeValue(values, "Maximum")); 
console.log(extremeValue(values, "Minimum"));

answered May 28, 2017 at 3:42

Mohammad Hamedani

3,3543 gold badges13 silver badges23 bronze badges

Comments

almost a beginner · Accepted Answer · 2017-05-28 03:52:18Z

1

Alternatively you can use the Math function to shorten your code:

var values = [4, 3, 6, 12, 1, 3, 7];
            
function extremeValue(array, maxmin) {
	if (maxmin === "Maximum") {
           return Math.max.apply(null, array);
	}
	else if (maxmin === "Minimum") {
	   return Math.min.apply(null, array);
	}
}
console.log(extremeValue(values, "Maximum")); 
console.log(extremeValue(values, "Minimum"));

answered May 28, 2017 at 3:52

almost a beginner

1,6322 gold badges20 silver badges43 bronze badges

Collectives™ on Stack Overflow

For loop not finding max value of array (Javascript)

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related