How To Fix This JavaScript Function?

Question

I want to add confirm box by using JavaScript. So, here is the code that I have used. When I click on the Delete button, it shows me a Confirmation message and when I click Ok, it doesn't delete my row.

What is wrong with this? How can I fix this?

a table

Here is the Index Page

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">

<html>
<head>
    <!-- Bootstrap core CSS -->
    <link href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.4/css/bootstrap.min.css" rel="stylesheet">
</head>
<body>
<div class="row"> <!-- Start Of The Row Class -->
<div class="col-md-8 col-sm-4 hero-feature"> <!-- Start Of The Col Class -->
<br><br>
<?php
error_reporting(E_ALL ^ E_DEPRECATED);
include('ksdb.php');
// get results from database
$result = mysql_query("SELECT * FROM academic")
or die(mysql_error());
?>
<table class='table table-bordered'>
<tr class='danger'> 
<th>ID</th> 
<th>Name</th> 
<th>Username</th> 
</tr>
<?php
// display data in table
while($row = mysql_fetch_array( $result )) {
	?>
<tr>
<td><?php echo $row['id']; ?></td>
<td><?php echo $row['name']; ?></td>
<td><?php echo $row['username']; ?></td>
<td><a href="AdminChangePw.php?id=<?php echo $row['id']; ?>" alt="edit" >Change</a></td>
 <td><a href="AdminEdit.php?id=<?php echo $row['id']; ?>" alt="edit" >Edit</a></td>
 <td><input type="button" onClick="deleteme(<?php echo $row['id']; ?>)" name="Delete" value="Delete"></td>
</tr>
<script language="javascript">
 function deleteme(delid)
 {
 if(confirm("Do you want Delete!")){
 window.location="AdminDel.php?id=' +id+'";
 return true;
 }
 } 
 </script>
<?php
}
?> 
 </table>
</div> <!-- End Of The Col Class -->
</div> <!-- End Of The Row Class -->
    <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.12.4/jquery.min.js"></script>
    <script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css"></script>
</body>
</html>

Is it removed from database?

Adharsh M
– Adharsh M

2017-05-28 10:37:41 +00:00
Commented May 28, 2017 at 10:37 — Adharsh M
– Adharsh M, Commented May 28, 2017 at 10:37
@AdhershMNair - No..

Kistlak Rajapaksha
– Kistlak Rajapaksha

2017-05-28 15:17:56 +00:00
Commented May 28, 2017 at 15:17 — Kistlak Rajapaksha
– Kistlak Rajapaksha, Commented May 28, 2017 at 15:17

Adharsh M · Accepted Answer · 2017-05-28 10:44:25Z

1

Change the id to 'delid'. You are calling the function as deleteme(delid). So You Must use delid, instead of id.

 function deleteme(delid)
 {
 if(confirm("Do you want Delete!")){
 window.location.href="AdminDel.php?id="+delid; /*Change id to 'delid'*/
 return true;
 }
 }

edited May 28, 2017 at 10:44

answered May 28, 2017 at 10:39

Adharsh M

2,7903 gold badges23 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Abhijit Parida Over a year ago

I think there shouldn't be single quotes around delid. OP is validating ids with is_numeric($_GET['id']) so an id with single quotes won't be considered valid.

Kistlak Rajapaksha Over a year ago

@AdhershMNair and Abhijit_Parida - Can I use this method to a link ?? echo '<td><a id="myLink" href="#" onclick="deleteme(<?php echo $row['id']; ?>)">Delete</a></td>';

Adharsh M Over a year ago

I think you mean like this .. <a id="myLink" href="AdminDel.php?id=<?php echo $row['id']; ?>">Delete</a>

imskm · Accepted Answer · 2017-05-28 10:40:31Z

0

Use window.location.href Instead of window.location

answered May 28, 2017 at 10:40

imskm

8051 gold badge15 silver badges27 bronze badges

1 Comment

Kistlak Rajapaksha Over a year ago

But, What is the different between window.location.href and window.location ??

Nick is tired · Accepted Answer · 2017-05-28 10:43:47Z

0

There are a couple of problems with your function:

function deleteme(delid) {
    if(confirm("Do you want Delete!")){
        window.location="AdminDel.php?id='+id+'";// this should be delid, also bad quotes, also you want to set the href, not the location
        return true;
    }
}

Fixed:

function deleteme(delid) {
    if(confirm("Do you want Delete!")){
        window.location.href="AdminDel.php?id=" + delid; 
        return true;
    }
}

answered May 28, 2017 at 10:43

Nick is tired

7,17721 gold badges44 silver badges55 bronze badges

Collectives™ on Stack Overflow

How To Fix This JavaScript Function?

3 Answers 3

3 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related