MySQL Error “Query was empty”

Question

$send_event = $db->query(sprintf("SELECT `bmembMember` FROM `bmembBusiness` = '%u' WHERE `bmembBusiness` = '%u' ORDER BY `bmembId` DESC", $bs['busId'])) OR die('Cron not run') ;
while($se=$db->fetch_row($send_event))
{
$text = "The {$bs['busName']} business went bankrupt\, all members have been made redundent." OR die('Cron not run');

Thanks

It's worth looking into using prepared statements and bind variables and you should also check for failures ($send_event may be false if the query fails) — Nigel Ren
– Nigel Ren, Commented May 29, 2017 at 10:54
Using sprintf does not at all secure your database from SQL injection. Look into what NigelRen has mentioned. — user5051310
– user5051310, Commented May 29, 2017 at 12:10

Nigel Ren · Accepted Answer · 2017-05-29 10:49:16Z

2

Your sprintf uses 2 values, but you only provide one. One isn't needed anyway and that line should be

$send_event = $db->query(sprintf("SELECT `bmembMember` FROM `bmembBusiness` WHERE `bmembBusiness` = '%u' ORDER BY `bmembId` DESC", $bs['busId'])) OR die('Cron not run') ;

answered May 29, 2017 at 10:49

Nigel Ren

57.3k11 gold badges49 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Qirel Over a year ago

"one isn't needed" is slightly inaccurate - it shouldn't be there at all, as you can't use FROM table = 'something', it's simply FROM table.

Strawberry Over a year ago

'Slightly inaccurate' !!

Danny Hermans Over a year ago

thanks for the reply when i use that i get 500 server error

Danny Hermans Over a year ago

and when i do it like this $send_event = $db->query(sprintf("SELECT bmembMember FROM WHERE bmembBusiness = '%u' ORDER BY bmembId DESC", $bs['busId'])) OR die('Cron not run') ; then i get ........QUERY ERROR: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE bmembBusiness = '3' ORDER BY bmembId DESC' at line 1 Query was SELECT bmembMember FROM WHERE bmembBusiness = '3' ORDER BY bmembId DESC

Nigel Ren Over a year ago

Your missing the table name in this SQL - FROM WHERE is missing something in the middle.

|

Conrad Lotz · Accepted Answer · 2017-05-29 10:50:09Z

1

Fix the FROM Clause which should fix the query.

 ...FROM `bmembBusiness` WHERE...

answered May 29, 2017 at 10:50

Conrad Lotz

8,9533 gold badges25 silver badges28 bronze badges

Comments

kuldeep upadhyay · Accepted Answer · 2017-05-29 11:33:15Z

-1

Highted area of query is wrong,

"SELECT bmembMember FROM bmembBusiness = '%u' WHERE bmembBusiness = '%u' ORDER BY bmembId DESC", $bs['busId'])

Try This Which should Fix the query :-

SELECT bmembMember FROM Table_name WHERE bmembBusiness Like '%u' ORDER BY bmembId DESC, abs(busId);

answered May 29, 2017 at 11:33

kuldeep upadhyay

421 silver badge8 bronze badges

1 Comment

user5051310 Over a year ago

Using Like instead of = changes the logic of the query. The reason the % is there is not for SQL but for sprintf

Collectives™ on Stack Overflow

MySQL Error “Query was empty”

3 Answers 3

8 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

8 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related