How to Create a JSONArray using JSONObject with all values from a database table in java

Question

I am fetching details from a database table which contains 3 rows in JAVA. I am using JSONarray and JSONObject as follows

JSONObject jsonObject = new JSONObject();
JSONObject mainjsonObject = new JSONObject();
JSONArray ja=new JSONArray();

The data from table is put to the jsonObject as follows for each one:

String qry="select * from details";
ResultSet res = select .executeQuery(qry);
while(res.next){

String Name=res.getString("name");
.
.

jsonObject.put("Name", Name);

.

.

ja.put(jsonObject);

}



mainjsonObject.put("PERSONAL DETAILS",ja);

i should get the output json as follows:

{
"PERSONAL DETAILS": [
    {
      " name": "abc",
      "age": "4",
      "gender": "F",
      "Place": "abc1"
    },
    {
      " name": "xyz",
      "age": "3",
      "gender": "M",
      "Place": "abc2"
    }


]

}

But am getting same values in both like below:

{

"PERSONAL DETAILS": [

    {

     " name": "abc",

     "age": "4",

     "gender": "F",

      "Place": "abc1"

    },

    {

   " name": "abc",

   "age": "4",

   "gender": "F",

   "Place": "abc1"

    }


]

}

Please help me with a solution. I need to get all the values from the tables as an array in JSON format

Pavneet_Singh · Accepted Answer · 2017-06-02 11:41:56Z

3

you need to create new JSONObject in your loop otherwise the last record will be shown everywhere

while(res.next()){

    String Name=res.getString("name");
    jsonObject = new JSONObject();
    // ^^^^^^^^
    jsonObject.put("Name", res.getString(1));
    jsonObject.put("age", res.getString(2));
    jsonObject.put("gender", res.getString(3));
    jsonObject.put("Place", res.getString(4));
    ja.put(jsonObject);
 }

edited Jun 2, 2017 at 11:41

answered Jun 2, 2017 at 11:30

Pavneet_Singh

37.5k5 gold badges57 silver badges71 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

fge Over a year ago

You beat me to it :p Except that there are some pieces of code missing from your example :)

Leeza Over a year ago

Thanks for ur reply @Pavneet_Singh. But can u pls cleary specify how to do it in the above one. Wat value to be given to the newly created JSONObject inside the loop

Pavneet_Singh Over a year ago

@Leeza as shown , get value from your resultset and put it inside jsonObject reference

Pavneet_Singh Over a year ago

@fge i guess you are talking about next() , copied the code from OP to save some time :P

Pavneet_Singh Over a year ago

i am glad that we (me & @fge & SO) could help , happy coding

|

fge · Accepted Answer · 2017-06-02 11:32:27Z

2

The problem is that you are reusing the same JSONObject over and over. And this is basically a Map.

What you need to do is create a new JSONObject instance and put it in the array for each iteration:

JSONObject obj;
while (rs.next()) {
    obj = new JSONObject();
    // fill in obj
    ja.put(obj);
}

answered Jun 2, 2017 at 11:32

fge

122k35 gold badges266 silver badges340 bronze badges

Collectives™ on Stack Overflow

How to Create a JSONArray using JSONObject with all values from a database table in java

2 Answers 2

6 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related