Array returning undefined when it should return something else?

Question

I am struggling with query.. I've been searching a lot, the only relevant posts I found had no answers.

row[0] returns undefined, I can't seem to find out why..

info:

As mentioned, logger.warn(rows[0]) returns undefined

rows.length returns 0

logger.warn(pool.escape(hash)) returns the correct hash(same as in DB)

logger.warn(rows[0].hash) returns undefined

This is the error in console/log file: TypeError: Cannot read property 'hash' of undefined

socket.on('hash', function(hash) {
        query('SELECT * FROM `members` WHERE `hash` = '+pool.escape(hash),
    function(err, rows) { 
            logger.warn(rows[0]) // returns "undefined"
            if((err) || (!rows.length)) return socket.disconnect();
    }

EDIT: QUERY FUNCITON

function query(sql, callback) {
if (typeof callback === 'undefined') {
    callback = function() {};
}
pool.getConnection(function(err, connection) {
    if(err) return callback(err);
    logger.info('DB Connection ID: '+connection.threadId);
    connection.query(sql, function(err, rows) {
        if(err) return callback(err);
        connection.release();
        return callback(null, rows);
    });
});

}

EDIT: Debug log

https://gyazo.com/858796b81c674ba816f974039eea1c09

EDIT: On disconnect

socket.on('disconnect', function() {
        logger.warn('Socket disconnect');
        io.sockets.emit('message', {
            type: 'logins',
            count: Object.size(io.sockets.connected)
        });
        delete users[user.email];
    })

Hash is defined, and returns the correct value. @Jiro90 EDIT: yes @RIYAJKHAN, I am, and that part is working fine. — Zander Møysal
– Zander Møysal, Commented Jun 6, 2017 at 2:43
@robertklep, sorry, I didn't include that. Edited post now. Hash is an email address. [email protected] returns test%40mail.com — Zander Møysal
– Zander Møysal, Commented Jun 6, 2017 at 16:45

robertklep · Accepted Answer · 2017-06-06 18:29:34Z

1

Looking at the log, it seems that the client is sending the hash event value like this: test%40mail.com.

However, as you state in your comment, in the database the value is stored as this: [email protected].

Which means that before running the query, you need to URI-unescape the hash value, and then SQL-escape it, before passing it to the database:

socket.on("hash", function(hash) {
  hash = pool.escape(decodeURIComponent(hash));
  query("SELECT * FROM `members` WHERE `hash` = " + hash, function(err, rows) {
    ...
  });
});

answered Jun 6, 2017 at 18:29

robertklep

205k38 gold badges421 silver badges412 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Array returning undefined when it should return something else?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related