PHP code not recognized in jQuery

Question

I have a function that is being called when I click a button. The data I pass on the function is not enclosed in a form tag so I have to manually include the csrf token:

function NewDeleteBox(box_id, batch_id, staff_id){
    $.ajax({
      url: 'oss/admin/delete_box',
      type: "POST",
      data: {'batch_id': batch_id, 'staff_id': staff_id, 'box_id': box_id, '<?php echo $this->security->get_csrf_token_name(); ?>': '<?php echo $this->security->get_csrf_hash();?>'},
      success: function(data) {
    
      }
    });
}

However, my csrf_token_name and hash is not working. It shows just like how I declare them in my data.

Any idea why I'm getting this? Thanks!

Yes. Because you are wrapping your PHP in quotes (thus turning them into strings )- so jQuery is going to treat it as a string - and so will your client. Also, your file needs to be .php — Korgrue
– Korgrue, Commented Jun 16, 2017 at 17:26
@RiazLaskar this is on a JS file. This is in codeigniter so the url is the subfolder/controller/method — elimariaaa
– elimariaaa, Commented Jun 16, 2017 at 17:28
You cannot put it in a JS file. .php extension tells your server to look for php in the file. It wont run PHP when the file extension is .js — Korgrue
– Korgrue, Commented Jun 16, 2017 at 17:29

Riaz Laskar · Accepted Answer · 2017-06-16 18:13:52Z

1

If you have put in all the code in a php file and still its not working then you can take another approach.

Put two hidden fields on the same page, assigned them unique id(s). and then in this ajax function, get their values using jQuery.

<input type="hidden" id="csrf" value="<?php echo $this->security->get_csrf_token_name(); ?>">
<input type="hidden" id="hash" value="<?php echo $this->security->get_csrf_hash();?>">

then your javascript function should be something like:

function NewDeleteBox(box_id, batch_id, staff_id){
var csrf = $("#csrf").val();
var hash = $("#hash").val();
var postdata = {'batch_id': batch_id, 'staff_id': staff_id, 'box_id': box_id};
postdata[csrf] = hash;
    $.ajax({
      url: 'oss/admin/delete_box',
      type: "POST",
      data: postdata ,
      success: function(data) {

      }
    });
}

edited Jun 16, 2017 at 18:13

Riaz Laskar

1,3229 silver badges17 bronze badges

answered Jun 16, 2017 at 17:39

Himanshu Upadhyay

6,5571 gold badge23 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

elimariaaa Over a year ago

yep I just did this. But the the hash is okay but the token name is not being picked up. I also tried directly adding those 2 when I call the function.but still the same. csrf: hash produces csrf: some_random_hash When I alert the csrf, it shows my token name. But when I add it on my data, it's just csrf.

Himanshu Upadhyay Over a year ago

Did you check these two hidden input values using developer tool (inspect element) of browser ?

elimariaaa Over a year ago

Yes. They have the right value. I'm confused as to why the token name is not being picked up. I also used alert(csrf); - it has the right value. But when I check the form data, the token name is literally csrf and not the actual name.

Himanshu Upadhyay Over a year ago

You should remove ' from the values. data: {batch_id: batch_id, staff_id: staff_id, box_id: box_id, csrf: hash},

Riaz Laskar · Accepted Answer · 2017-06-16 17:30:49Z

1

php code wont work on a .js file. just put it in a .php file inside script tags it should work fine.

<script>
function NewDeleteBox(box_id, batch_id, staff_id){
    $.ajax({
      url: 'oss/admin/delete_box',
      type: "POST",
      data: {'batch_id': batch_id, 'staff_id': staff_id, 'box_id': box_id, '<?php echo $this->security->get_csrf_token_name(); ?>': '<?php echo $this->security->get_csrf_hash();?>'},
      success: function(data) {

      }
    });
}
</script>

edited Jun 16, 2017 at 17:30

answered Jun 16, 2017 at 17:29

Riaz Laskar

1,3229 silver badges17 bronze badges

8 Comments

Korgrue Over a year ago

And the php script cannot be wrapped in quotes - else it will be treated as a string.

Riaz Laskar Over a year ago

@Korgrue you are incorrect !!!, php code works in quotes too , u cn test it yourself, infact in situations if u dont put quotes u will get a js error.

elimariaaa Over a year ago

@RiazLaskar All my js functions are in an external file so I want to stick with that. Thanks for pointing out my error. :)

Riaz Laskar Over a year ago

then pass them as arg to the function it should work fine.

elimariaaa Over a year ago

I tried that but I encountered the same issue with @Himanshu Upadhyay's approach. The token name is not being picked up.

|

Collectives™ on Stack Overflow

PHP code not recognized in jQuery

2 Answers 2

4 Comments

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related