type casting when creating an instance from a parent class

Question

I would like to ask something about type-casting in Swift.

There are 2 classes.

RootViewController
MyViewController

and the class hierarchy is like below:

class RootViewController: UIViewController {

}

class MyViewController: RootViewController {

}

and, I want to simply call instance function to create an instance from xib file. so I implemented below function in RootViewController.

Objective-C

+ (instancetype)instance {
    return [[[self class] alloc] initWithNibName:NSStringFromClass([self class]) bundle:nil];
}

Swift

public class func instance<T:RootViewController>() -> T {
    let type = self as UIViewController.Type
    let name = NSStringFromClass(type).components(separatedBy: ".").last!
    let instance = type.init(nibName: name, bundle: nil)
    return instance as! T
}

and, usage is like below.

Objective-C

MyViewController *vc = [MyViewController instance];

Swift

let vc = MyViewController.instance() as! MyViewController

Question:

Do I have to always cast the type of instance using as! MyViewController in Swift? Or can anybody advise me a better approach in Swift?

Any help would be appreciated!

I don't see any problem or question here. I would personally avoid using instance or any other factory methods in swift, because you can't use Self as a return type. Use regular init methods instead. — kelin
– kelin, Commented Jun 19, 2017 at 9:48
And, I must add, this question is better to be asked on codereview.stackexchange.com — kelin
– kelin, Commented Jun 19, 2017 at 9:53
Compare Return instancetype in Swift – you want a return type of Self, using a generic helper function in order to perform the cast. — Hamish
– Hamish, Commented Jun 19, 2017 at 9:54

hardikdevios · Accepted Answer · 2017-06-19 09:49:53Z

3

You can Also use like this way

let vc:MyViewController = MyViewController.instance()

answered Jun 19, 2017 at 9:49

hardikdevios

1,78914 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Orkhan Alikhanov · Accepted Answer · 2017-06-19 11:24:57Z

2

class RootViewController: UIViewController {
    public class func instance() -> Self {
        func inner<T: RootViewController>(type: T.Type) -> T {
            let name = NSStringFromClass(type).components(separatedBy: ".").last!
            let type1 = type as UIViewController.Type
            let instance = type1.init(nibName: name, bundle: nil)
            return instance as! T
        }
        return inner(type: self)
    }
}

I would suggest creating an extension method:

extension UIViewController {
    public class func instance() -> Self {
        func inner<T: UIViewController>(type: T.Type) -> T {
            let name = NSStringFromClass(type).components(separatedBy: ".").last!
            return T(nibName: name, bundle: nil)
        }
        return inner(type: self)
    }
}

edited Jun 19, 2017 at 11:24

answered Jun 19, 2017 at 9:46

Orkhan Alikhanov

10.2k4 gold badges50 silver badges66 bronze badges

7 Comments

kelin Over a year ago

This wouldn't even compile.

Orkhan Alikhanov Over a year ago

@kelin As if OP's does.

Orkhan Alikhanov Over a year ago

@kelin check now.

kelin Over a year ago

@OrkhanAlikhanov, now I'm getting the following error: "Cannot convert value of type 'Self.Type' to expected argument type 'RootViewController.Type'"

Orkhan Alikhanov Over a year ago

@kelin I run it and it failed to cast, fixed. Now working.

|

nayem · Accepted Answer · 2017-06-19 09:55:58Z

0

Okay you can instantiate in these three ways:

Swift inference to Type:

let myVC = RootViewController.instance()   //Swift will automatically infer the type

Explicitly telling the Type:

let myVC: RootViewController = RootViewController.instance()

Casting to your Type:

let myVC = RootViewController.instance() as! RootViewController

All these three are valid.

answered Jun 19, 2017 at 9:55

nayem

7,6131 gold badge37 silver badges56 bronze badges

Collectives™ on Stack Overflow

type casting when creating an instance from a parent class

3 Answers 3

Comments

7 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

7 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related