56

I'm using BASH, and I don't know how to find a substring. It keeps failing, I've got a string (should this be an array?)

Below, LIST is a string list of database names, SOURCE is the reply, one of those databases. The following still doesn't work:

echo "******************************************************************"
echo "*                  DB2 Offline Backup Script                     *"
echo "******************************************************************"
echo "What's the name of of the  database you would like to backup?"
echo "It will be named one in this list:"
echo ""
LIST=`db2 list database directory | grep "Database alias" | awk '{print $4}'`
echo $LIST
echo ""
echo "******************************************************************"
echo -n ">>> "
read -e SOURCE

if expr match "$LIST" "$SOURCE"; then
    echo "match"
    exit -1
else
    echo "no match"
fi
exit -1

I've also tried this but doesn't work:

if [ `expr match "$LIST" '$SOURCE'` ]; then
Improve this question
4
  • 1
    It's hard to answer any sort of question without knowing what LIST and SOURCE looks like Commented Dec 17, 2010 at 4:41
  • 1
    In Bash, there's almost always no reason to use expr which is an external utility. Commented Dec 17, 2010 at 5:21
  • yes that one solved it: stackoverflow.com/questions/229551/string-contains-in-bash Commented Dec 17, 2010 at 5:21
  • 1
    Possible duplicate of String contains a substring in Bash. Commented Jun 11, 2018 at 0:16

8 Answers 8

Reset to default
91 
LIST="some string with a substring you want to match"
SOURCE="substring"
if echo "$LIST" | grep -q "$SOURCE"; then
  echo "matched";
else
  echo "no match";
fi
Improve this answer
Sign up to request clarification or add additional context in comments.

1 Comment

2 issues to consider with this approach: (1) grep uses regex so some chars will match unexpected or cause errors; (2) Using grep (or anything that's not built in to bash) spawns a separate process which will run slower (only matters in larger scale cases).
38

You can also compare with wildcards:

if [[ "$LIST" == *"$SOURCE"* ]]

Improve this answer

3 Comments

You should always quote the strings, like: if [[ "$list" == *"$source"* ]]
Note that if [[ *"$SOURCE"* == "$LIST$" ]] is false.
I've confirmed that the order is important/mandatory - so *"$SOURCE"* must be in the right - otherwise always returns false - why that behavior?
9

This works in Bash without forking external commands:

function has_substring() {
   [[ "$1" != "${2/$1/}" ]]
}

Example usage:

name="hello/world"
if has_substring "$name" "/"
then
   echo "Indeed, $name contains a slash!"
fi
Improve this answer

2 Comments

The advantage to this solution is that it doesn't rely on any external commands nor file descriptors (via redirection or pipes).
Note that this is using a regex to search for the substring (and also does an out-of-place replace), so special chars in the search (substring) can cause unexpected results. But if regex is fine, then why not just do a regex search (ie. no need for the replace)? Syntax example: if [[ "$string" =~ $substring ]]
7

If you're using bash you can just say

if grep -q "$SOURCE" <<< "$LIST" ; then
    ...
fi
Improve this answer

Comments

1

You can use "index" if you only want to find a single character, e.g.:

LIST="server1 server2 server3 server4 server5"
SOURCE="3"
if expr index "$LIST" "$SOURCE"; then
    echo "match"
    exit -1
else
    echo "no match"
fi

Output is:

23
match
Improve this answer

Comments

1 
expr match "$LIST" '$SOURCE'

don't work because of this function search $SOURCE from begin of the string and return the position just after pattern $SOURCE if found else 0. So you must write another code:

expr match "$LIST" '.*'"$SOURCE" or expr "$LIST" : '.*'"$SOURCE"

The expression $SOURCE must be double quoted so as a parser may set substitution. Single quoted not substitute and the code above will search textual string $SOURCE from the beginning of the $LIST. If you need the beginning of the string subtract the length $SOURCE e.g ${#SOURCE}. You may write also

expr "$LIST" : ".*\($SOURCE\)"

This function just extract $SOURCE from $LIST and return it. You'll get empty string else. But they problem with double double quote. I don't know how it resolve without using additional variable. It's light solution. So you may write in C. There is ready function strstr. Don't use expr index, So is very attractive. But index search not substring and only first char.

Improve this answer

Comments

0

expr is used instead of [ rather than inside it, and variables are only expanded inside double quotes, so try this:

if expr match "$LIST" "$SOURCE"; then

But I'm not really clear what SOURCE is supposed to represent.

It looks like your code will read in a pattern from standard input, and exit if it matches a database alias, otherwise it will echo "ok". Is that what you want?

Improve this answer

Comments

0

Well, what about something like this:

PS3="Select database or <Q> to quit: "
select DB in db1 db2 db3; do
   [ "${REPLY^*}" = 'Q' ] && break
   echo "Should backup $DB..."
done
Improve this answer

Comments

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.