SQL syntax error using jdbc

Question

I don't know what is the error in this section of could please help

here is my code

public void addEmploye(Employe employe, Service service) throws SQLException{
    int id_service = getServiceId(service);
    if(nbrPersonnes(employe.getCin())!=0)
        System.out.println("Employe deja existant verifier le cin");
    else{
     String SQL = "insert into Employe(post) "
            + "values ("
            + "'"+employe.getPost()+"')"

            + "insert into Personne(cin,nom,prenom,adresse,tel,email,password,id_directeur,id_employe,id_service)"
            + "values('"+employe.getCin()+"',"
            + "'"+employe.getNom()+"',"
            + "'"+employe.getPrenom()+"',"
            + "'"+employe.getAdresse()+"',"
            + "'"+employe.getTel()+"',"
            + "'"+employe.getEmail()+"',"
            + "'"+employe.getPassword()+"',"
            + "0,"
            + " SELECT LAST_INSERT_ID() FROM `Personne`,"
            +id_service+")";
     if(id_service!=0)
         try {
             stmt = con.createStatement();  
             rs = stmt.executeUpdate(SQL);
        } catch (SQLException e) {
            System.out.println("addEmploye "+e.toString());
        }
    }
}

and here is the error

    addEmploye com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'insert into Personne(cin,nom,prenom,adresse,tel,email,password,id_directeur,id_e' at line 1
addEmploye com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'insert into Personne(cin,nom,prenom,adresse,tel,email,password,id_directeur,id_e' at line 1
addEmploye com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'insert into Personne(cin,nom,prenom,adresse,tel,email,password,id_directeur,id_e' at line 1
addEmploye com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'insert into Personne(cin,nom,prenom,adresse,tel,email,password,id_directeur,id_e' at line 1
addEmploye com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'insert into Personne(cin,nom,prenom,adresse,tel,email,password,id_directeur,id_e' at line 1
addEmploye com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'insert into Personne(cin,nom,prenom,adresse,tel,email,password,id_directeur,id_e' at line 1

my teamparnter wrote this code for MSSQL but I want now use it under Mysql SGBD I find this problem any suggestion please

You have no space between these two statements. + "'"+employe.getPost()+"')" + "insert into Personne( — SS_DBA
– SS_DBA, Commented Jun 26, 2017 at 17:32
Can you have 2 inserts in the same block? Don't you at least need a semi-colon? — TedTrippin
– TedTrippin, Commented Jun 26, 2017 at 17:39
Try printing out the statement and see if it works directly in MySQL. — SS_DBA
– SS_DBA, Commented Jun 26, 2017 at 17:39
@TedTrippin no and no - semi-colon is not valid in SQL statements (some drivers don't allow it, other just ignore it). — user85421
– user85421, Commented Jun 26, 2017 at 18:02

user85421 · Accepted Answer · 2017-06-26 18:05:47Z

1

A SQL statement can only contain ONE statement, your code is trying to execute insert into Employe(post) values (...)insert into Personne(....

This must be divided in two SQL commands, executed separately: insert into Employe(post) values (...) and insert into Personne(.... You can use the same Statement instance, but executeUpdate must be called two times.

And it is indicated to use a PreparedStatement as suggested by Jamal H.

edited Jun 26, 2017 at 18:05

answered Jun 26, 2017 at 17:59

user85421

29.8k11 gold badges66 silver badges96 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jamal H · Accepted Answer · 2017-06-26 17:34:15Z

1

You must have an error somewhere in that long SQL statement, or one of the parameters you are passing contains something messing up the statement.

You should never use that kind of method for SQL inserts. Use prepared statements: Prepared Statements

Prepared statements makes the code way cleaner, and prevents things like SQL injections. Implement that and you should be able to fix your insert statement

answered Jun 26, 2017 at 17:34

Jamal H

1,0941 gold badge10 silver badges25 bronze badges

Collectives™ on Stack Overflow

SQL syntax error using jdbc

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related