Replacing objects' names outside the scope in Python

Question

This is probably has a very solution but I am struggling with this a bit. I have 3 almost similar functions I'd like to refactor into one.

Here's the function:

def delete_labels_replication_controller(provider, obj_type):
    obj_label_list = []
    obj_type_list = provider.mgmt.list_replication_controller()

def delete_labels_node(provider, obj_type):
    obj_label_list = []
    obj_type_list = provider.mgmt.list_node()

def delete_labels_image(provider, obj_type):
    obj_label_list = []
    obj_type_list = provider.mgmt.list_image()

Now, as you see, the only thing that changes is the provider.mgmt.xxx class and it changes according to the obj_type I want to pass into the function. Question is how to use only 1 function for all of them and replace only the .xxx part of the object? Thanks!

Not stated in the question, but am I right to assume that there's coming more after those two lines? Because otherwise, none of those three functions is doing anything at all. — tobias_k
– tobias_k, Commented Jul 3, 2017 at 14:32
Yes, there's more. I just leave what's relevant to my question — Pavel Zagalsky
– Pavel Zagalsky, Commented Jul 3, 2017 at 14:32

wefner · Accepted Answer · 2017-07-03 14:39:21Z

1

I am sure there is a better solution but maybe using getattr like this?

def delete_labels_by_type(obj_type):
    obj_type_list = getattr(provider.mgmt, obj_type)()     
    return obj_type_list

answered Jul 3, 2017 at 14:39

wefner

262 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2020-06-20 09:12:55Z

0

Do like this

def myFunction(provider, obj_type, flag_type)
    obj_label_list = []
    if flag_type == 1:
        obj_type_list = provider.mgmt.list_replication_controller()
    elif flag_type == 2:
        obj_type_list = provider.mgmt.list_node()
    elif flag_type == 3:
        obj_type_list = provider.mgmt.list_image()

edited Jun 20, 2020 at 9:12

CommunityBot

11 silver badge

answered Jul 3, 2017 at 14:26

Tilak Putta

7784 silver badges18 bronze badges

1 Comment

bruno desthuilliers Over a year ago

DONT "do like this", there is a way better solution.

tobias_k · Accepted Answer · 2017-07-03 14:48:50Z

0

You could just pass the obj_type_list as another parameter to the function:

def delete_labels(provider, obj_type, obj_type_list):
    obj_label_list = []
    ...

and then call like this delete_labels(provider, obj_type, provider.mgmt.list_replication_controller()) (and if that's the only time you need the provider parameter, you can remove it entirely)

Or pass a reference to the getter method:

def delete_labels(provider, obj_type, getter):
    obj_label_list = []
    obj_type_list = getter(provider.mgmt)
    ...

and then call like this: delete_labels(provider, obj_type, MgmtClass.list_replication_controller)

In both cases, you can move the bulk of the three functions (the common part not shown in the question) into that new function and keep the original functions for easier usage:

def delete_labels_replication_controller(provider, obj_type):
    return delete_labels(provider, obj_type, provider.mgmt.list_replication_controller())

answered Jul 3, 2017 at 14:48

tobias_k

83.1k12 gold badges130 silver badges186 bronze badges

1 Comment

tobias_k Over a year ago

Personally, I would use the first variant to reduce code duplication and combine it with the third for easier usage in the remaining code.

Collectives™ on Stack Overflow

Replacing objects' names outside the scope in Python

3 Answers 3

Comments

Do like this

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Do like this

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related