nodejs: write multiple files in for loop

Question

I am still learning nodejs. This question is related to a few others (e.g., Writing multiple files a loop in Nodejs) but a bit different. It is actually quite simple. I want to write a number of files and when it is all done continue on other task.

Without for loop, I am doing like this,

fs.readFile(f1.path, function(err, data) {
    fs.writeFile("/tmp/" + f1.path, data, function(err) {
        fs.readFile(f2.path, function(err, data) {
            fs.writeFile("/tmp/" + f2.path, data, function(err) {
                ...
                if (err) throw err;

                // do something when all files are written

If I want to convert it using for loop, how to do it? Suppose I could put f1, f2 ... into an array and iterate them.

Thank you for the help.

Brett Beatty · Accepted Answer · 2017-07-11 17:51:20Z

6

You can save promises in an array and use Promise.all to wait for them to all finish:

const fs = require('fs');
const path = require('path');

const files = [f1, f2, ...];

function copyFile(source, destination) {
    const input = fs.createReadStream(source);
    const output = fs.createWriteStream(destination);
    return new Promise((resolve, reject) => {

        output.on('error', reject);
        input.on('error', reject);
        input.on('end', resolve);
        input.pipe(output);
    });
}

const promises = files.map(file => {
    const source = file.path;
    const destination = path.join('/tmp', file.path);
    // Use these instead of line above if you have files in different
    // directories and want them all at the same level:
    // const filename = path.parse(file.path).base;
    // const destination = path.join('/tmp', filename);
    return copyFile(source, destination);
});

Promise.all(promises).then(_ => {
    // do what you want
    console.log('done');
}).catch(err => {
    // handle I/O error
    console.error(err);
});

answered Jul 11, 2017 at 17:51

Brett Beatty

6,0642 gold badges29 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user180574 Over a year ago

Works well. I will pick up your answer. Thanks a lot!

peteb · Accepted Answer · 2017-07-11 17:09:17Z

You can use recursion to do this without another library. The below code will copy files from an Array, waiting for the prior file to finish copying before moving on to the next asynchronously.

Approach using fs.readFile() and fs.writeFile()

const fs = require('fs')
const path = require('path')

// your files array
let files = [f1, f2]

function copyFile (index, cb) {
  let file = files[index]
  let dest = path.join('/tmp', file.path)
  if (!file) {
    // done copying
    return cb(null)
  }
  fs.readFile(file.path, (err, data) => {
    if (err) {
      // return callback with error
      return cb(err)
    } else {
      fs.writeFile(dest, data, (err) => {
        if (err) {
          return cb(err)
        } else {
          copyFile(index + 1, cb)
        }
      })
    }
  })
}

copyFile(0, (err) => {
    if (err) {
      // Handle Error
        console.log(err)
    } else {
      console.log('Files Copied Successfully!')
    }
})

Approach using streams, better in my opinion

const fs = require('fs')
const path = require('path')

// your files array
let files = [f1, f2]

function copyFile(index, cb) {
    let file = files[index]
    let dest = path.join('/tmp', file.path)

    if (!file) {
        return cb(null)
    }

    let source = fs.createReadStream(file.path)
    let copy = fs.createWriteStream(dest)

    source.on('error', err => {
      // explicitly close writer
      copy.end()
      return cb(err)
    })

    copy.on('error', err => {
      return cb(err)
    })

    copy.on('finish', () => {
      copyFile(index + 1, cb)
    })

    source.pipe(copy)
}

copyFile(0, (err) => {
    if (err) {
      // Handle Error
        console.log(err)
    } else {
      console.log('Files Copied Successfully!')
    }
})

Abdullah Shahin · Accepted Answer · 2017-07-11 18:54:55Z

Here is another way

    const fs = require("fs");
    const listOfFiles = [{fileName:"a.txt",data:"dummy data!"},{fileName:"b.txt",data:"dummy data b!"},{fileName:"c.txt",data:"dummy data c!"},{fileName:"d.txt",data:"dummy data d!"},{fileName:"e.txt",data:"dummy data e!"}];

    listOfFiles.reduce(function(curFile, nextFile){
            return writeData(nextFile).then();
    }, writeData);

    console.log("Another Code to be executed!");
    console.log("Another Code to be executed!");
    console.log("Another Code to be executed!");
    console.log("Another Code to be executed!");

    function writeData(params){
      return new Promise((resolve,reject)=>{
        fs.writeFile(params.fileName,params.data,'utf8',(err)=>{
           if(err)
              reject(err);
           else
              resolve();
          });
     });
}

TheBotlyNoob · Accepted Answer · 2021-06-25 04:02:45Z

0

STEP 1 : Install `fs-extra`

npm i -D fs-extra

Documentation : https://www.npmjs.com/package/fs-extra

STEP 2 : Write files with `fs.outputFile`

const fs = require('fs-extra');
// Async
fs.outputFile(file, data, [options, callback])
// Sync
fs.outputFileSync(file, data, [options])

If output directories are not there, they will be created recursively.

Good Luck...

edited Jun 25, 2021 at 4:02

TheBotlyNoob

3685 silver badges17 bronze badges

answered Mar 12, 2019 at 3:47

Aakash

24.1k7 gold badges110 silver badges89 bronze badges

Collectives™ on Stack Overflow

nodejs: write multiple files in for loop

4 Answers 4

1 Comment

Comments

Comments

STEP 1 : Install `fs-extra`

STEP 2 : Write files with `fs.outputFile`

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

STEP 1 : Install fs-extra

STEP 2 : Write files with fs.outputFile

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related

STEP 1 : Install `fs-extra`

STEP 2 : Write files with `fs.outputFile`