Using a conditional inside a foreach loop when adding to array

Question

I'm having trouble getting this to work. I'm scraping a website using a xpath selector and this returns 38 results which are added to the array $list. Now the first 5 results and the last 3 are useless to me. What I need is to only add results 6-35 to the array. I've tried many different combinations of if, for and while conditionals but can't seem to get this to work. I'd love to hear what I'm doing wrong and finally get this to work.

$url = "www.theurl.com";
$html = new DOMDocument();
@$html->loadHtmlFile($url);
$xpath = new DOMXPath($html);

$nodelist = $xpath->query("//span[@class='mp-listing-title']");

$list = array();

$i = 0;

foreach ($nodelist as $n) {
  $i++;
}
if ($i >=5 && $i <=35) {
  $value = $n->nodeValue;
  $list[] = $value;
}

Thanks for your help!

you are closing foreach loop too early leaving the if condition out of the loop or is that a typo....? — Sudhir Bastakoti
– Sudhir Bastakoti, Commented Jul 18, 2017 at 10:54

Sonu Bamniya · Accepted Answer · 2017-07-18 10:56:15Z

2

Try this, it can help you:

 $url = "www.theurl.com";
 $html = new DOMDocument();
 @$html->loadHtmlFile($url);
 $xpath = new DOMXPath($html);

 $nodelist = $xpath->query("//span[@class='mp-listing-title']");

 $list = array();

 $i = 0;

 foreach ($nodelist as $n) {
   if ($i >=5 && $i <=35) {
     $value = $n->nodeValue;
     $list[] = $value;
   }
   $i++;
 }

answered Jul 18, 2017 at 10:56

Sonu Bamniya

1,1301 gold badge14 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Peon Over a year ago

Since nodelist is obviously a list array, wouldn't it be more correct to use for($i=0; $i<count($nodelist); $i++) and then access $nodelist[$i]->nodeValue instead of foreach and then manually increment $i?

Sonu Bamniya Over a year ago

Here is a better desciprition of your question PHP for() VS foreach()

Matt Rink · Accepted Answer · 2017-07-18 10:57:02Z

0

Try the following:

$url = "www.theurl.com";
$html = new DOMDocument();
@$html->loadHtmlFile($url);
$xpath = new DOMXPath($html);

$nodelist = $xpath->query("//span[@class='mp-listing-title']");

$list = array();

$i = 0;

foreach ($nodelist as $n)  {
  if ($i >=5 && $i <=35) {
    $value = $n->nodeValue;
    $list[] = $value;
  }
  $i++;
}

Your conditional was out side of the loop.

answered Jul 18, 2017 at 10:57

Matt Rink

3452 silver badges12 bronze badges

Collectives™ on Stack Overflow

Using a conditional inside a foreach loop when adding to array

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related