JavaScript substr on jQuery html() of a JavaScript variable

Question

What I'm trying to ask is that when I take on a .each loop in jQuery using a build of a string by this:

$('.list :checkbox').each(function()
{
    var type = $(this).attr('value');
    Build += type + ', ';

    return Build;
});

But now I need to remove the last "," (without quotes) since it makes a list like this:

Item 1, Item 2, Item 3, Item 4, Item 5,

Then it has to be added to the html() function which works well, but when trying to remove the last "," doesn't work by doing this:

Build.substr(-1);

$('#list-box').html(Build);

But that won't work.

Use this.value instead of $(this).attr('value'). It's faster and more readable. — Šime Vidas
– Šime Vidas, Commented Dec 24, 2010 at 17:11

Andrew Whitaker · Accepted Answer · 2010-12-24 18:07:22Z

2

You could simplify your code with something like this:

(updated)

var arr = $(":checkbox").map(function() {
    return this.value;
}).get();


$('#list-box').html(arr.join(","));

Try it here: http://jsfiddle.net/andrewwhitaker/rXB2K/ (also updated)

Uses the map() function to translate the jquery results array to an array of checkbox values.
Calls join(), separating each value with a comma.

edited Dec 24, 2010 at 18:07

answered Dec 24, 2010 at 17:13

Andrew Whitaker

126k32 gold badges296 silver badges308 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

stealthyninja · Accepted Answer · 2010-12-24 17:10:08Z

1

@YouBook: Try

Build.substr(0, Build.length - 1);

instead.

answered Dec 24, 2010 at 17:10

stealthyninja

10.4k11 gold badges56 silver badges61 bronze badges

Comments

rlayte · Accepted Answer · 2010-12-24 17:11:39Z

0

Have you tried using substring instead of substr? e.g.

Build.substring(Build.length - 1);

answered Dec 24, 2010 at 17:11

rlayte

5384 silver badges12 bronze badges

Comments

ifaour · Accepted Answer · 2010-12-24 17:13:33Z

0

Build = Build.slice(0,-1);

works?

answered Dec 24, 2010 at 17:13

ifaour

38.1k12 gold badges74 silver badges79 bronze badges

Comments

Šime Vidas · Accepted Answer · 2010-12-24 17:17:58Z

0

Instead this:

return Build;

write this:

return Build.substr(0, Build.length-1);

answered Dec 24, 2010 at 17:17

Šime Vidas

187k66 gold badges290 silver badges392 bronze badges

Comments

Infinite Recursion · Accepted Answer · 2014-09-09 04:16:35Z

0

Don't use initial caps for variables.

Also, Strings are immutable in JS, so it's

   build = build.substring(0, b.length-1)

This is a general purpose function called join in most languages, you should break it out as a utility function.

You should take into account the possibility of a zero length list.

edited Sep 9, 2014 at 4:16

Infinite Recursion

6,57528 gold badges42 silver badges51 bronze badges

answered Dec 24, 2010 at 17:09

Michael Lorton

44.7k26 gold badges111 silver badges159 bronze badges

Collectives™ on Stack Overflow

JavaScript substr on jQuery html() of a JavaScript variable

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related