Recursive function works only without a class, but not with class

Question

I have a php code which performs directory/file listing. However, it does not work when called by object.

Following Code Works :

function getDirContents($dir, &$results = array()){
$files = scandir($dir);

foreach($files as $key => $value){
    $path = realpath($dir.DIRECTORY_SEPARATOR.$value);
    if(!is_dir($path)) {
        $results[] = $path;
    } else if($value != "." && $value != "..") {
        getDirContents($path, $results);
        $results[] = $path;
    }
}
// print_r($results);
return $results;
}

var_dump(getDirContents('C:\xampp\htdocs\skillup\d4a1'));

The following code DOES NOT work :

class Dira {
function getDirContents($dir, &$results = array()){
$files = scandir($dir);

foreach($files as $key => $value){
    $path = realpath($dir.DIRECTORY_SEPARATOR.$value);
    if(!is_dir($path)) {
        $results[] = $path;
    } else if($value != "." && $value != "..") {
        getDirContents($path, $results);
        $results[] = $path;
    }
}
// print_r($results);
return $results;
}

}

$obj = new Dira;
$arr = array();
var_dump($obj->getDirContents('C:\xampp\htdocs\skillup\d4a1'));

yes, but apparently it works with object only if there are no sub-directories inside the given path of the directory — PHP Enthu
– PHP Enthu, Commented Aug 3, 2017 at 10:40

Anees Saban · Accepted Answer · 2017-08-03 10:58:08Z

2

Your mistake is in your method, your method calls itself recursively via:

getDirContents();

but should do so like (in your Dira class):

$this->getDirContents();

edited Aug 3, 2017 at 10:58

answered Aug 3, 2017 at 10:49

Anees Saban

6056 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

prakash tank · Accepted Answer · 2017-08-03 11:00:09Z

1

You are using recursive function getDirContents() but when you call it again you are missing $this .

Try Below Example :

class abc{
    public function getDirContents($dir, &$results = array()){ 
    $files = scandir($dir);

        foreach($files as $key => $value){
            $path = realpath($dir.DIRECTORY_SEPARATOR.$value);
            if(!is_dir($path)) {
                $results[] = $path;
            } else if($value != "." && $value != "..") {
                $this->getDirContents($path, $results);
                $results[] = $path;
            }
        }
    return $results;
    }
}
$res = new abc();
$re = $res->getDirContents('YOUR PATH');
echo '<pre>'; print_r($re);

answered Aug 3, 2017 at 11:00

prakash tank

1,2671 gold badge9 silver badges15 bronze badges

Collectives™ on Stack Overflow

Recursive function works only without a class, but not with class

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related