javascript replace character with loop

Question

This should be simple but I am not sure why it isn't working:

function kebabToSnake (str){
    var string = "";
    var chart = "";
    for(i=0; i < str.lenght; i++){
        if (str.charAt(i) == "-") {
            chart = "_";
            string = string + chart;
        }
        else {
            chart = str.charAt(i);
            string = string + chart;
        }
    }
    return string
}

I know I could do it with str.replace(/-/g,"_") but I cannot see what's wrong with the above, besides being too long. Any help would be great.

What happens when you debug your code (eg, step through it line-by-line in the debugger)? What do you see? — user663031
– user663031, Commented Aug 6, 2017 at 2:48

basement · Accepted Answer · 2017-08-06 13:57:59Z

3

You spelled "length" wrong. ( on line 4 )

It works after the spelling correction.

function kebabToSnake (str){
    var string = "";
    var chart = "";
    for(i=0; i < str.length; i++){  //fixed spelling from 'str.lenght'
        if (str.charAt(i) == "-") {
            chart = "_";
            string = string + chart;
        }
        else {
            chart = str.charAt(i);
            string = string + chart;
        }
    }
    return string
}

var body = document.querySelector( 'body' ),
    output = kebabToSnake( '-' ); //First test with '-' in conditional statement

body.innerHTML = output; //display to body

output = kebabToSnake( 'Another String' ); //Second test with random text triggering ELSE statement

body.innerHTML += '<br>' + output; //display to body

edited Aug 6, 2017 at 13:57

answered Aug 6, 2017 at 2:38

basement

7182 gold badges8 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Lucas A Over a year ago

Lol I can't believe I didn't notice, it was driving me crazy. Thank you!!!

tibetty · Accepted Answer · 2017-08-06 06:57:08Z

-1

You can achieve this goal by using RegExp more concisely:

function kebabToSnake (str) {
    return str.replace(/-/g, '_');
}

edited Aug 6, 2017 at 6:57

answered Aug 6, 2017 at 2:49

tibetty

5632 silver badges10 bronze badges

2 Comments

tibetty Over a year ago

‘coz '-' is a special purpose character in RegExp, so it should be escaped when you use it as a plain character to match.

tibetty Over a year ago

Yes, maybe you are right. But in practice, I always ask my programmers to escape it 'coz there's no negative effect on correctness.

Collectives™ on Stack Overflow

javascript replace character with loop

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related