Ruby loop problems

Question

I am working on a script that is supposed to be writing a list of items to a hash, but for some reason its only placing the last item in the loop in the hash... I have been working on this script all day, so I am pretty sure its something I am just missing.

Here is the script

@mr = MediaRating.where("user_id = ?", session['user_credentials_id'])
@mr.each do |rating|
  @m = Media.where("id = ?", rating.media_id)
  @m.each do |m|
    s = Profile.find_by_subscriber_id(m.subscriber_id)
    @h_lang = Language.find_by_code(s.language)
    @history = {m.title => @h_lang.english}
  end
end

There are multiple records in the MediaRating table so I know it has to do something with how my loop is. Thanks in advance for the help!

Working code:

@mr = MediaRating.where("user_id = ?", session['user_credentials_id'])
@mr.each do |rating|
  @m = Media.find(rating.media_id)
  s = Profile.find_by_subscriber_id(@m.subscriber_id)
  @h_lang = Language.find_by_code(s.language)
  @history[@m.title] = @h_lang.english
end

side note: these finds with id shows that you are not using associations (has_many, belongs_to, ...) — tokland
– tokland, Commented Dec 29, 2010 at 22:52

Stephen Petschulat · Accepted Answer · 2010-12-29 22:43:20Z

13

In the last line, you are over-writing the entire @history hash instead of adding a new key/value pair to it. I'm guessing that isn't what you intended. Change this line:

@history = {m.title => @h_lang.english}

to this:

@history[m.title] = @h_lang.english

answered Dec 29, 2010 at 22:43

Stephen Petschulat

1,1772 gold badges14 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

dennismonsewicz Over a year ago

I knew it was something simple!!! Thanks! I was even able to simplify my loops too! Added new code above.

karatedog Over a year ago

@dennismonsewicz: Then it is time for you to push that big fat outlined check-mark for this answer.

Collectives™ on Stack Overflow

Ruby loop problems

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related