Page not changing when using header function in PHP but works with Javascript

Question

I am creating a very simple website with user accounts. In my 'login.php', the login details are sent via a form to the page 'home.php' where the username/password are checked with a database and then:

If they are correct, the HTML in my page home.php is displayed. If they are not correct, the HTML is not displayed and I use the 'header' function to go back to the login.php page.

Here is my code :

<?php
    if ($identification==1) { // IF THE IDENTIFICATION IS CORRECT
?>
// Here all the HTML of my page is displayed
<?php   
    }else{ 
        header ('location : login.php'); 
    }
?>

When I do it this way, the redirection is not made and I just have a blank page, but when I change it to:

<?php
    if ($identification==1) { 
?>
<!-- Here all the HTML of my page is displayed -->
<?php   
    }else{ 
?>
echo "<script type='text/javascript'>document.location.replace('login.php');</script>";
<?php
    }
?>

It works perfectly! Do you have an idea why it is not working with header?

Also, is it secured to do the check of username/password directly in the home page, or should I do it in a 'test.php' page which would redirect to the 'home.php' page if the credentials are correct ?

EDIT, works like this

  if ($identification!=1) { header ('Location: home.php'); exit;
  };

Location and remember to add an exit after the header line. — Jonnix
– Jonnix, Commented Aug 23, 2017 at 8:38
In the very top of your script, just have: if ($identification != 1) { header('Location: login.php'); exit; }. Then you don't need to wrap the whole site in an else-block. Just make sure that there is no output before your header()-call, not even a space/blank line or it won't work. — M. Eriksson
– M. Eriksson, Commented Aug 23, 2017 at 8:44
Thanks for the tip, much better! I edited my question, doesnt seem to be working :( — Olivia Delpierre
– Olivia Delpierre, Commented Aug 23, 2017 at 9:04

Mr Pro Pop · Accepted Answer · 2017-08-23 08:58:06Z

1

I checked and tried to find out the problem! The results are the way you added the redirection is wrong:

Use this instead! colon : should be appended to location!

<?php
    if ($identification==1) { // IF THE IDENTIFICATION IS CORRECT
?>
// Here all the HTML of my page is displayed
<?php   
    }else{ 
        header('Location: login.php'); 
    }
?>

I hope this helped!

answered Aug 23, 2017 at 8:58

Mr Pro Pop

6765 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Mr Pro Pop Over a year ago

@OliviaDelpierre You are welcome, please accept the answer if this helped you ;)

jyotisankar · Accepted Answer · 2017-08-23 08:58:24Z

0

You don't have to check username password on homepage, instead you should check it either in login.php or may be an action file of login.php. If the username and passwords are correct you can set a session value and can redirect the user to home.php based on the session value, else you can redirect the user to login.php

Now for the use of header you can simply use

if( // check your condition here...) {
    header("location:home.php");
    exit();
}else{
    header("location:login.php");
    exit();
}

answered Aug 23, 2017 at 8:58

jyotisankar

1441 silver badge4 bronze badges

Collectives™ on Stack Overflow

Page not changing when using header function in PHP but works with Javascript

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related