Object initializer with conditional statement

Question

How can I simplify conditional statement inside object initializer so that code will be more readible? If addNew is true, then new item is added to dictionary, otherwise it will have only one item.

...
var channel = new ChannelConf {
Name = "Abc"
Headers = !addNew ?  new Dictionary<string, string> 
          { 
               [Constants.Key1] = Id
          }
          : new Dictionary<string, string>
          {
               [Constants.Key1] = Id,
               [Constants.Key2] = Port
          }
}
...

you might think of using constructor overloading new ChannelConf(bool addNew) — ibubi
– ibubi, Commented Aug 25, 2017 at 22:34
How about not using conditionals in initalizers? if (addNew) { channel.Headers.Add(Constants.Key2, Port); } after the initialization is a vast improvement. Remember, initializers are only shorthand for after-the-fact property assignments anyway. You do not get a prize for squeezing everything in one block. — Jeroen Mostert
– Jeroen Mostert, Commented Aug 25, 2017 at 22:36

Trisped · Accepted Answer · 2017-08-25 22:42:23Z

1

You could call a method to initialize Headers:

...
new ChannelConf {
Name = "Abc"
Headers = GetNewDictionary(addNew)
}
...

private Dictionary<string, string> GetNewDictionary(bool addNew)
{
    Dictionary<string, string> output = new Dictionary<string, string> { [Constants.Key1] = Id };

    if (addNew) { output.Add(Constants.Key2, Port); }

    return output;
}

Alternately, you could leave it the way that it is and reduce the number of lines:

...
var channel = new ChannelConf {
Name = "Abc"
Headers = !addNew ?  new Dictionary<string, string>  { [Constants.Key1] = Id }
          : new Dictionary<string, string> { [Constants.Key1] = Id, [Constants.Key2] = Port }
}
...

answered Aug 25, 2017 at 22:42

Trisped

6,0442 gold badges51 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

ibubi · Accepted Answer · 2017-08-25 23:06:10Z

0

I think it is a good practice to let things done through a parameterized constructor. It might be a common api consumed by others, so it is going to be easy for you to document and not have to tell how consumer should use the api.

public ChannelConf(bool addNew)
{
    Headers = !addNew
        ? new Dictionary<string, string>
        { [Constants.Key1] = Id }
        : new Dictionary<string, string>
        {
            [Constants.Key1] = Id,
            [Constants.Key2] = Port
        };
}

answered Aug 25, 2017 at 23:06

ibubi

2,5494 gold badges32 silver badges54 bronze badges

Collectives™ on Stack Overflow

Object initializer with conditional statement

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related