delete property doesn't work in node.js

Question

I wonder why I can't delete password object, my console result shows the password is still there, I wonder why.

User.comparePassword(password, user.password , (err, result) => {
  if (result === true){
    User.getUserById(user._id, (err, userResult) => {
      delete userResult.password

      const secret = config.secret;
      const token = jwt.encode(userResult, secret);

      console.log(userResult)

      res.json({success: true, msg: {token}});
    });
  } else {
    res.json({success: false, msg: 'Error, Incorrect password!'});
  }
}

if that doesn't work, can you move console.log(userResult) right below delete userResult.password? just to be sure that jwt.encode doesn't mutate userResult somehow. — Federkun
– Federkun, Commented Aug 27, 2017 at 10:13

Ivan Vasiljevic · Accepted Answer · 2017-08-27 11:26:30Z

9

There are multiple solutions to your problem. You cannot delete property from Mongoose query, because you get some Mongoose wrapper. In order to manipulate object you need to transform it to JSON object. So there are three possible way that I can remember to do that:

1) Call toObject method mongoose object (userResult) like this:

 let user = userResult.toObject();
 delete user['password'];

2) Redefine toJson method of User model:

UserSchema.set('toJSON', {
        transform: function(doc, ret, options) {
            delete ret.password;
            return ret;
        }
});

3) Query can return object without specified field, so that you don't need to delete anything:

 User.findById(user._id, {password: 0}, function (err, userResult) {
   ...
 }

answered Aug 27, 2017 at 11:26

Ivan Vasiljevic

5,7282 gold badges33 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Jenny Mok Over a year ago

Wow thanks so much didn't know it has anything to do with mongoose.

Ivan Vasiljevic Over a year ago

I am glad I could help you :)

Collectives™ on Stack Overflow

delete property doesn't work in node.js

1 Answer 1

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related