How to check if an input is empty using JavaScript

Question

Ok so I have an HTML input element

<input name="name" type="text" id="name" placeholder="Name" />

and in JavaScript I do :

var ninp = document.getElementById("name");
if(ninp.value == ""){
  do stuff
} else{
  do other stuff
}

Everytime I run the function it fires the "else" block of code I'm I doing something wrong or this isnt a correct way :/

It should be if(ninp == "") because you're already grabbing the value in the first line. — Andy
– Andy, Commented Aug 27, 2017 at 13:41
Is that the whole function because that code works as it should (it's using the first condition, not the second). — Andy
– Andy, Commented Aug 27, 2017 at 13:45

Mahdi P. · Accepted Answer · 2017-08-27 13:45:56Z

1

In first line of your code, you have gotten value of input tag. so you have something like this:

ninp = "a string ..."

and so it is impossible to have something like ninp.value in your condition in second line.

change

if(ninp.value == ""){
do stuff
}

to

if(ninp == ""){
 do stuff
}

answered Aug 27, 2017 at 13:45

Mahdi P.

3072 silver badges5 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Andy Over a year ago

The OP updated the question. This is no longer the case.

KrisGeor · Accepted Answer · 2017-08-27 13:54:08Z

0

Maybe something else in the function was breaking it but the answer was just to test for the length of the string

var ninpv = ninp.value;
if(ninpv.lenght == 0;){
do stuff
}

answered Aug 27, 2017 at 13:54

KrisGeor

531 silver badge6 bronze badges

Comments

Suresh Sapkota · Accepted Answer · 2017-08-27 14:13:50Z

0

You can also check in this way

var ninp = document.getElementById("name").value;
if(ninp.length === 0){
  do stuff
} else {
  do other stuff
}

answered Aug 27, 2017 at 14:13

Suresh Sapkota

2694 silver badges7 bronze badges

Comments

Ans Bilal · Accepted Answer · 2017-08-27 14:23:31Z

0

why do not you move to jquery and write

var ninp = $('#name');
if(ninp.val() =="")
{
//do stuff
}else
//otherstuff

or 
if(ninp.val().length==0)

Also keep it in mind if you are using JS form external files browser mostly do not load your updated js files. In this case I mostly use incognito mode of browser

answered Aug 27, 2017 at 14:23

Ans Bilal

1,0771 gold badge12 silver badges29 bronze badges

Collectives™ on Stack Overflow

How to check if an input is empty using JavaScript

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related