bulk create using ListSerializer of Django Rest Framework

Question

Iam trying to bulk create rows for a certain table using Django Rest Framework. I see in the documentation that DRF supports it.

views.py

class UserProfileFeedViewSet(viewsets.ModelViewSet):
    """Handles creating, reading and updating profile feed items."""

    authentication_classes = (TokenAuthentication,)
    queryset = models.ProfileFeedItem.objects.all()
    serializer_class = serializers.ProfileFeedItemSerializer(queryset, many=True)
    permission_classes = (permissions.PostOwnStatus, IsAuthenticated)

    def perform_create(self, serializer):
        """Sets the user profile to the logged in user."""

        serializer.save(user_profile=self.request.user)

serializers.py

class ProfileFeedItemListSerializer(serializers.ListSerializer):
   def create(self,validated_data):
       feed_list = [ProfileFeedItem(**item) for item in validated_data]
       return ProfileFeedItem.objects.bulk_create(feed_list)

class ProfileFeedItemSerializer(serializers.ModelSerializer):
    """A serializer for profile feed items."""

    class Meta:
        model = models.ProfileFeedItem
        list_serializer_class = ProfileFeedItemListSerializer
        fields = ('id', 'user_profile', 'status_text', 'created_on')
        extra_kwargs = {'user_profile': {'read_only': True}}

When i try posting using admin form i always get this error. Can you please help me identify what am i doing wrong here ?

TypeError at /api/feed/ 'ProfileFeedItemListSerializer' object is not callable Request Method: GET Request URL: http://127.0.0.1:8080/api/feed/ Django Version: 1.11 Exception Type: TypeError Exception Value: 'ProfileFeedItemListSerializer' object is not callable Exception Location: /home/ubuntu/.virtualenvs/profiles_api/local/lib/python3.5/site-packages/rest_framework/generics.py in get_serializer, line 111 Python Executable: /home/ubuntu/.virtualenvs/profiles_api/bin/python Python Version: 3.5.2

score 8 · Accepted Answer · 2017-08-29 04:27:00Z

8

try it:

def create(self, request, *args, **kwargs):
    many = isinstance(request.data, list)
    serializer = self.get_serializer(data=request.data, many=many)
    serializer.is_valid(raise_exception=True)
    self.perform_create(serializer)
    headers = self.get_success_headers(serializer.data)
    return Response(serializer.data, headers=headers)

def perform_create(self, serializer):
    if type(serializer.validated_data) == list:
         for item in serializer.validated_data:
              item.update({'user_profile': self.request.user})
    else:
        serializer.validated_data.update({'user_profile': self.request.user})
    serializer.save()

unfortunately now I can't check the solution, but maybe it will give right way

edited Aug 29, 2017 at 4:27

answered Aug 28, 2017 at 12:31

user8060120

Sign up to request clarification or add additional context in comments.

9 Comments

Prasanna Over a year ago

Iam able to post single dictionary datasets with this but posting list of dictionaries continues to throw AttributeError: 'list' object has no attribute 'get'

Prasanna Over a year ago

when i pass a list of dataset the code flow does not even reach perform_create. It always expects the data to be passed as a dictionary. There must be a way to tell DRF that the incoming data is a list of dictionaries and not a single dictionary.

user8060120 Over a year ago

added the create method

Prasanna Over a year ago

Awesome...that created the multiple rows for passed dataset. But the AttributeError: 'list' object has no attribute 'get' trace still shows up in console..How do i suppress it ?

Prasanna Over a year ago

The AttributeError occurs only while i post from Django Admin form. It does not occur while posting via postman.

|

Arpit Solanki · Accepted Answer · 2017-08-28 11:23:41Z

1

Serializer_class should be class, not class instance. Try to change this

serializer_class = serializers.ProfileFeedItemSerializer(queryset, many=True)

to this:

serializers.ProfileFeedItemSerializer

edited Aug 28, 2017 at 11:23

Arpit Solanki

10k4 gold badges45 silver badges57 bronze badges

answered Aug 28, 2017 at 11:21

neverwalkaloner

47.6k7 gold badges101 silver badges103 bronze badges

6 Comments

Prasanna Over a year ago

I changed that. Iam trying to post the following dataset: [{ "status_text": "Hello" },{ "status_text": "World" } ] Now when i submit the form i see following error in console: AttributeError: 'list' object has no attribute 'get'

neverwalkaloner Over a year ago

@Prasanna can you add full error text to the question?

neverwalkaloner Over a year ago

@Prasanna try to add serializer = self.get_serializer(data=self.request.data, many=True) before serializer.save(user_profile=self.request.user) line in UserProfileFeedViewSet

Prasanna Over a year ago

Added the get_serializer but still the same error as full trace above...

neverwalkaloner Over a year ago

@Prasanna I changed my comment, did you try it?

|

Collectives™ on Stack Overflow

bulk create using ListSerializer of Django Rest Framework

2 Answers 2

9 Comments

6 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

9 Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related