Unable to run a db query within a php function

Question

I have created a function in my views and have tried to make a query within the php function but i do not know I am getting and unexpected error which was never been seen in my entire career can anyone help me out to get rid from this error?

Severity: Error --> Using $this when not in object context /application/views/includes/create_calendar.php 51

This is my controller

class Booking extends CI_Controller {
    public function __construct() {
        parent::__construct();
        $this->load->helper(array("form", "url"));
        $this->load->library('session');
        $this->load->database();
    }

    public function get_calendar() {
        $this->load->view('includes/create_calendar');
    }
}

This is the file in which I am trying to run a query views/includes/create_calendar.php

function getCalender($year = '',$month = '') {  
   $sql       = $this->db->get('calendar');
   if($day == $sql->row()->day_off) { $per_off = $sql->row()->per_off; }

                        echo "<p>".$day." Off</p>";
}

I updated my answer. To know why it is happening, see this: php.net/manual/en/language.variables.scope.php — Brian Gottier
– Brian Gottier, Commented Sep 4, 2017 at 21:45

Brian Gottier · Accepted Answer · 2017-09-04 21:44:15Z

1

In CodeIgniter usage, if you need to use one of the classes that is available in the "super object", you must first get an instance of the super object:

$CI =& get_instance();
$CI->db->get('calendar');

This DB class may not even be loaded. If that's the case, then before you use db:

$CI->load->database();

To clarify, as soon as you go in that function, you've removed $this from the variable scope, like this simple test:

class Test {

    public $foo = 'bar';

    public function index() {
        function baz(){
            return $this->foo;
        }
        echo baz();
    }
}

$t = new Test;
$t->index();

You could do something like the following, but that's really messy:

class Test {

    public $foo = 'bar';

    public function index() {
        function baz($x) {
            return $x->foo;
        }
        echo baz($this);
    }
}

$t = new Test;
$t->index();

The best thing for you to do is find another cleaner way to do what you are doing. You wouldn't normally want calls to your database and functions in your views. It goes against what MVC is all about.

edited Sep 4, 2017 at 21:44

answered Sep 4, 2017 at 21:27

Brian Gottier

4,6003 gold badges24 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Usman Khan Over a year ago

but many times i tried to call a query within the views it runs fine why did this error came in now

Brian Gottier Over a year ago

Based on your code, I can't tell you why. I can just tell you that this is how you get to the CodeIgniter super object when it doesn't exist. It could happen in libraries, helpers, or anywhere else too. I guess variable scope could come into play here. Being that you're inside a function.

Collectives™ on Stack Overflow

Unable to run a db query within a php function

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related