Codeigniter extending extended MY_Controller

Question

I have strictly followed the how-to article by Phil Sturgeon, to extend the base controller. But I get still some errors.

My 3 classes:

// application/libraries/MY_Controller.php
class MY_Controller extends Controller{
    public function __construct(){
        parent::__construct();
    }
}

// application/libraries/Public_Controller.php
class Public_Controller extends MY_Controller{
    public function __construct(){
        parent::__construct();

    }    
}

// application/controllers/user.php
class User extends Public_Controller{
    public function __construct(){
        parent::__construct();
    }
}

Fatal error: Class 'Public_Controller' not found in /srv/www/xxx/application/controllers/user.php on line 2

Curious is that the following snippet is working, if I directly extends from MY_Controller:

// application/controllers/user.php
class User extends MY_Controller{
    public function __construct(){
        parent::__construct();
    }
}

I have loaded the controllers via __autoload() or manually. The controllers are loaded succesfully.

CI-Version: 1.7.3

Are you loading MY_Controller.php before Public_Controller.php is loaded? — Alisson
– Alisson, Commented Jan 5, 2011 at 22:03
There are much better answers in this question: stackoverflow.com/questions/21663045/… even as if it's marked as a duplicated of this — Federico J.
– Federico J., Commented Jul 31, 2014 at 15:33

Teej · Accepted Answer · 2011-01-06 08:17:23Z

7

You need to require the Public Controller in your MY_Controller

// application/libraries/MY_Controller.php
class MY_Controller extends Controller{
    public function __construct(){
        parent::__construct();
    }
}

require(APPPATH.'libraries/Public_Controller.php');

You get the error because Public_Controller was never loaded. Doing this would allow you to extend from Public_Controller

I like what you are doing because I do that all the time.

You can do this also in your MY_Controller when you want to create an Admin_Controller

// application/libraries/MY_Controller.php
class MY_Controller extends Controller{
    public function __construct(){
        parent::__construct();
    }
}

require(APPPATH.'libraries/Public_Controller.php'); // contains some logic applicable only to `public` controllers
require(APPPATH.'libraries/Admin_Controller.php'); // contains some logic applicable only to `admin` controllers

edited Jan 6, 2011 at 8:17

answered Jan 6, 2011 at 8:08

Teej

12.9k9 gold badges76 silver badges94 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Teej Over a year ago

@Phil, he missed that part in your post :)

Phil Sturgeon Over a year ago

Oh. "I have loaded the controllers via __autoload() or manually." Who knows :)

Hashem Qolami Over a year ago

To those want to use this snippet: Since version 2 Controller core class is changed to CI_Controller.

Ijas Ameenudeen Over a year ago

@Phil What about using hooks ? I have used this method, stackoverflow.com/a/22125436/567854

jondavidjohn · Accepted Answer · 2012-03-26 13:32:04Z

5

You should place Public_controller in with MY_Controller inside MY_Controller.php

// application/libraries/MY_Controller.php
class MY_Controller extends Controller{
    public function __construct(){
        parent::__construct();
    }
}

class Public_Controller extends MY_Controller{
    public function __construct(){
        parent::__construct();

    }    
}

I use __construct everywhere and it works fine I recently wrote up an article on how to do this in relation to wrapping your auth logic into your extended controllers. It's about half way down when I start discussing constructing your controllers.

edited Mar 26, 2012 at 13:32

answered Jan 6, 2011 at 4:42

jondavidjohn

62.5k21 gold badges120 silver badges159 bronze badges

Comments

devcrap.net · Accepted Answer · 2011-09-05 20:48:50Z

1

Problem was solved here: http://devcrap.net/pl/2011/09/04/codeigniter-dziedziczenie-z-my_controller-extends-my_controller/. In polish but code is good :]

answered Sep 5, 2011 at 20:48

devcrap.net

111 bronze badge

Comments

shihabudheen · Accepted Answer · 2012-07-18 19:38:33Z

1

I had problem like this,After some search I found error was made myself,Because my controller class name was MY_Controller but file name was My_Controller[Case not matching]. Note:- In localhost I didnt have any error.

In extended controller I Use

class Home  extends MY_Controller{
   function __construct() {
   parent::__construct();
  }
}

even I got the error.

After changing my file name to MY_Controller it started to work well.

edited Jul 18, 2012 at 19:38

answered Jul 18, 2012 at 19:32

shihabudheen

3031 gold badge5 silver badges11 bronze badges

Comments

Ángel R.G. · Accepted Answer · 2017-08-09 09:20:11Z

I have a custom controller class called MY_Controller it extends CI_Controller and it works fine. It is located at application/core and it has custom functions lo load views in my site.

I use an abstract class My_app_controller that extends MY_Controller for my_app specific behabior, I want every controller in my_app to extend this abstract class. (I use diferent apps in the site, so some apps will extend My_app_controller and other apps will extend My_other_apps_controllers)

But when I try to extend My_app_controller from any controller in my application, "Main_app_controller extends My_app_controller" generates a Class 'My_app_controller' not found exception.

I found two solutions:

use include_once in Main_app_controller.php file.
include_once APPPATH.'controllers/path/to/My_app_controler.php';
break the "one class per file" rule of code igniter and define my My_app_controller just in the same file MY_Controller is (under application/core).

Manual says:

Use separate files for each class, unless the classes are closely related

Well... they are.

Anyway, I prefered to use the include_once solution as I think it is better to have one file per class and My_app_controller is located under application/controllers/my_app folder. (so application/controllers/other_apps will exist)

Collectives™ on Stack Overflow

Codeigniter extending extended MY_Controller

5 Answers 5

4 Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

4 Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related