Throws exception while Type casting from String to Int.

Question

I have no idea what is going wrong here. Code Snippet

       b1.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            try {
                String s1=SpinnerObj.getSelectedItem().toString();
                String n1=s1.substring(s1.indexOf("Rs")+2,s1.length()-1);
                int ns1=Integer.parseInt(String.valueOf(n1));//Couldnt cast and throws Exception
                Toast.makeText(getBaseContext(),""+ns1,Toast.LENGTH_LONG).show();
                Intent i = new Intent(getBaseContext(),OrderPlaced.class);
                startActivity(i);
            }
                catch (NumberFormatException nfe) {
                Toast.makeText(getBaseContext(), "gg", Toast.LENGTH_LONG).show();
            }
        }});

here i m trying to Type cast the String getting from Spinner to integer for computaions.

Converting String to int is sometimes not possible when it has more than integers.It will throw exception.Try to use use String value and check once — Sharath kumar
– Sharath kumar, Commented Sep 8, 2017 at 8:04
Be sure there is no space or anyother string value in your n1 string, It must contains only numeric value. OR may be n1 value is null. Post logcat and your strings too to get more clear idea. — AndiM
– AndiM, Commented Sep 8, 2017 at 8:04
i have spinner value as "Havells fan(Rs 900)". and m getting 900 in n1. — Viddyut Khanvilkar
– Viddyut Khanvilkar, Commented Sep 8, 2017 at 8:05

Omkar · Accepted Answer · 2017-09-08 08:19:34Z

3

IMO you are taking incorrect first index of substring try below code

  String test = "Havells fan(Rs 900)";
        String n1=test.substring(test.indexOf("Rs")+3,test.length()-1);\\ use +3 instead of +2
        int ns1 = Integer.parseInt(String.valueOf(n1));
        Toast.makeText(getBaseContext(),""+ns1,Toast.LENGTH_LONG).show();

answered Sep 8, 2017 at 8:19

Omkar

3,1001 gold badge26 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Iulian Popescu · Accepted Answer · 2017-09-08 08:35:44Z

0

Based on the string you gave in comments: Havells fan(Rs 900) you include a whitespace in your string while computing the starting index for the number because s1.indexOf("Rs")+2(this computation will give 14) will point to the whitespace (index 14), not to 9(index 15). For a proposed a solution, you can use any of the existing answers either trimming the string (n1.trim()) or counting the space char when you compute the starting index(s1.indexOf("Rs")+3).

answered Sep 8, 2017 at 8:35

Iulian Popescu

2,6434 gold badges25 silver badges31 bronze badges

Comments

Ryan M · Accepted Answer · 2022-07-10 16:39:32Z

-1

maybe the string has a space. you should use n1.trim()

edited Jul 10, 2022 at 16:39

Ryan M♦

20.6k35 gold badges75 silver badges85 bronze badges

answered Sep 8, 2017 at 8:10

杜咸鱼

195 bronze badges

Collectives™ on Stack Overflow

Throws exception while Type casting from String to Int.

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related