#include "stdafx.h"
int _tmain(int argc, _TCHAR* argv[])
{
float x[1000][1000];
return 0;
}
I get " First-chance exception at 0x01341637 in s.exe: 0xC00000FD: Stack overflow." why?
-
1Read this: stackoverflow.com/questions/216259/…Loki Astari– Loki Astari2011-01-07 20:03:45 +00:00Commented Jan 7, 2011 at 20:03
-
Also: stackoverflow.com/questions/1847789/…Charles Salvia– Charles Salvia2011-01-07 20:08:55 +00:00Commented Jan 7, 2011 at 20:08
Add a comment
|
4 Answers
Your array is simply too large to fit on the stack. You don't have enough stack space for 1000 * 1000 elements.
You'll need to allocate your array on the heap. You can do this using the new keyword, but an easier way is to just use std::vector.
std::vector<std::vector<float> > floats(1000);
for (unsigned i = 0; i != floats.size(); ++i) floats[i].resize(1000);
This will give you a two-dimensional vector of floats, with 1000 elements per vector.
Also see: Segmentation fault on large array sizes
12 Comments
wkl
@HPT - one solution is to use dynamically allocated memory, or use something like a vector of vector.
user541686
You can also do a static array of dynamic arrays (aka an array of pointers). Just be aware that the dynamic arrays won't be contiguous in memory.
Puppy
You could also just make the array static. This should be fine.
Gene Bushuyev
no need to write loop when the library does it for you: std::vector<std::vector<float> > floats(1000, std::vector<float>(1000, 0.0));
Stack Overflow is garbage
@TonyK: not in my experience. It usually just leads to more moving stuff around until it works. Repeat until moving stuff around no longer makes it work, at which point the "programmmer" usually gives up.
|
float is 4 bytes, so 4 * 1000 * 1000 = 4 megabytes.
"stack size defaults to 1 MB"
See here: http://msdn.microsoft.com/en-us/library/tdkhxaks(v=VS.100).aspx
3 Comments
Zac
really, you should probably use some sort of dynamic container, like @birryee is suggesting.
Loki Astari
Approx 3.8 megabytes. With the assumption that sizeof(float) == 4
Billy ONeal
This also assumes you're using Windows and MSVC.
As others explained, the size of the object is bigger than the (default) size defined for function stack frame. There are two solutions: 1) create an object on the heap, which is likely to be bigger; or 2) increase the function stack frame size, which can be problematic in 32-bit environment, because you can run out of addressable space, but it can easily be done in 64-bits.
Comments
Just declare your array static:
static float x[1000][1000];
Edited to add:
Sigh Another silent downvoter. Not that I'm surprised. This is obviously the simplest solution to OP's problem, so it violates the prime tenet of the OOP Komissariat: The simplest solution is always wrong.
