Using enums in Java across multiple classes

Question

I have the following class:

public class Card 
{
    public enum Suit 
    {
        SPACES, HEARTS, DIAMONDS, CLUBS
    };

    public Card(Suit nsuit, int nrank)
    {
        suit = nsuit;
        rank = nrank;
    }

    private Suit suit;
    private int rank;
}

I want to instantiate it in another class, but that class doesn't understand the Suit enum. Where should I put the enum to make it publicly visible?

BTW, the ; after your Suit decl is unnecessary.

Bert F
– Bert F

2011-01-08 16:51:56 +00:00
Commented Jan 8, 2011 at 16:51 — Bert F
– Bert F, Commented Jan 8, 2011 at 16:51

user8681 · Accepted Answer · 2011-01-08 16:53:01Z

31

The Suit enum is inside the Card class, and you have to access it that way:

new Card(Card.Suit.SPADES, 1);

Or, you can import the Suit class from within Card, and access it directly:

import my.package.Card.Suit;
new Card(Suit.SPADES, 1);

The other option is to put Suit in its own class, as suggested by Bert.

answered Jan 8, 2011 at 16:53

user8681

Sign up to request clarification or add additional context in comments.

Comments

Bert F · Accepted Answer · 2011-01-08 16:47:40Z

25

Put Suit in its own class:

Suit.java:

public enum Suit 
{
    SPACES, HEARTS, DIAMONDS, CLUBS
}

answered Jan 8, 2011 at 16:47

Bert F

88k12 gold badges114 silver badges126 bronze badges

3 Comments

Igor Over a year ago

Thanks. I've been thinking about that but I thought that all classes needed the class keyword.

Bert F Over a year ago

@Richard - Yeah, it was surprising to me the first time I saw it.

user8681 Over a year ago

This does solve the problem, but I don't think it's the best solution. The Suit enum belongs in the Card class, since you'll always use them together.

robert_x44 · Accepted Answer · 2011-01-08 16:52:03Z

6

The enum is already visible.

Card card = new Card(Card.Suit.CLUBS, 5);

will instantiate a new card.

Unrelated... but you might want to make the Spaces suit into the Spades suit. :)

answered Jan 8, 2011 at 16:52

robert_x44

9,3741 gold badge35 silver badges37 bronze badges

Comments

NorthCat · Accepted Answer · 2014-09-18 07:08:53Z

-5

The Suit enum is inside the Card class, and you have to access it that way:

Card.Suit suit = Card.Suit.CLUBS;

edited Sep 18, 2014 at 7:08

NorthCat

10k16 gold badges51 silver badges56 bronze badges

answered Sep 18, 2014 at 6:43

krishna

1

1 Comment

msysmilu Over a year ago

error: unexpected type required: class,package found: variable

Collectives™ on Stack Overflow

Using enums in Java across multiple classes

4 Answers 4

Comments

3 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

3 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related