PHP displaying error code once

Question

When a user clicks login, "Wrong Email Or Password" Is displayed for each user that is in Database Array. Could someone point me in the right direction to Only Display Error code once if user input wrong email/password? I'm Using Flintstone to store Users.

    if (isset($_POST['login'])) {
    $TempEmail = strtolower($_POST['email']);
    $TempPass = $_POST['password'];
    // Get Keys From DB;
    $keys = $users->getKeys();
    // Check If DB is Empty
    if (!empty($keys)) {
        foreach ($keys as $key) {
            $user = $users->get($key);
            $email = strtolower($user['Email']);
            $password = $user['Password'];
            $hash = password_verify($TempPass, $password);
            try {
                if (($TempEmail === $email) && ($hash === true))
                {
                    $_SESSION['use']=$email;
                    // On Successful Login redirects to home page
                    header("Location:/home/");
                }
                else
                {
                    echo "Wrong Email Or Password";
                    //break;
                }
            } catch (Exception $e) {
                return $e->getMessage();
            }
        }
    } else {
        echo "DB Is Empty";
        exit;
    }
}

@chris85 If I Uncomment //break, then it will only run on 1 user in the array and quit. — danielsokil
– danielsokil, Commented Sep 24, 2017 at 0:29
Use WHERE in your query to only fetch the user with that email. — M. Eriksson
– M. Eriksson, Commented Sep 24, 2017 at 0:30
Oh, yea. I was looking at this wrong. Assign it to a variable and echo the variable after execution. This should probably be done another way though. — chris85
– chris85, Commented Sep 24, 2017 at 0:30
@MagnusEriksson This is not SQL, I'm using xeweb.net/flintstone — danielsokil
– danielsokil, Commented Sep 24, 2017 at 0:31

M. Eriksson · Accepted Answer · 2017-09-24 00:40:09Z

1

Simply move echo "Wrong Email Or Password" right after the foreach-loop instead of inside it. If the email is found and the password matches, the user will still be redirected before the code reaches that point.

foreach ($keys as $key) {
    // Your current code, minus the echo.
}

// This is after the foreach and will only be executed if there were
// no match for the email and password.
echo "Wrong Email Or Password";

Just remember to add an exit; after your header('Location:....'); to stop PHP from executing anything more.

answered Sep 24, 2017 at 0:40

M. Eriksson

13.7k4 gold badges31 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

danielsokil Over a year ago

How couldn't I think of this? Wow, Thank's So Much. Any Ideas How I could improve my code?

M. Eriksson Over a year ago

@Danik - No worries. It's easy to miss obvious solutions sometimes :-)

M. Eriksson Over a year ago

@Danik - To start with, you can remove your whole try/catch since it doesn't serve any purpose in that context. You don't have anything that could throw an Exception in that case.

nefu_01 · Accepted Answer · 2017-09-24 00:39:58Z

0

The foreach loop goes through all the $keys, hence it echoes "Wrong Email Or Password" for every wrong key. Save the outcome of a successfull query in a variable i.e. $success = false. If the correct login was found, set it to true. After the foreach loop you can write

if(!$success){echo "Wrong password"};

edited Sep 24, 2017 at 0:39

answered Sep 24, 2017 at 0:28

nefu_01

163 bronze badges

2 Comments

danielsokil Over a year ago

What is the best solution in this case?

nefu_01 Over a year ago

Well, as Magnus Eriksson answered the best way would be to change the SQL query. If you can't do that, then a quick guess would be to save the outcome of a successfull query in a variable i.e. $success = false. If the correct login was found, set it to true. After the foreach loop you can put a if(!$success){echo "Wrong password"};

obfish · Accepted Answer · 2017-09-24 00:42:20Z

0

I think this is more user-friendly:

$login = false;
foreach ($keys as $key) {
    $user = $users->get($key);
    $email = strtolower($user['Email']);
    $password = $user['Password'];
    $hash = password_verify($TempPass, $password);
    try {
        if ($TempEmail === $email) {
            if ($hash === true) {
                $login = true;
                $_SESSION['use'] = $email;
                // On Successful Login redirects to home page
                header("Location:/home/");
            } else {
                break;
            }
        }
    } catch (Exception $e) {
        return $e->getMessage();
    }
}
if (!$login) {
    echo "Wrong Email Or Password";
}

answered Sep 24, 2017 at 0:42

obfish

6774 silver badges21 bronze badges

Collectives™ on Stack Overflow

PHP displaying error code once

3 Answers 3

3 Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related