Fix Error: Image Upload Script - Only variables should be passed by reference

Question

Testing a file upload script I am getting this error message : Strict Standards: Only variables should be passed by reference in

Offending line 8 is: $file_ext=strtolower(end(explode('.',$_FILES['image']['name'])));

How can I fix this ?

Here is the full script I am trying to use as published at

https://www.tutorialspoint.com/php/php_file_uploading.htm

Script shown below:

<?php
   if(isset($_FILES['image'])){
      $errors= array();
      $file_name = $_FILES['image']['name'];
      $file_size = $_FILES['image']['size'];
      $file_tmp = $_FILES['image']['tmp_name'];
      $file_type = $_FILES['image']['type'];
      $file_ext=strtolower(end(explode('.',$_FILES['image']['name'])));

      $expensions= array("jpeg","jpg","png");

      if(in_array($file_ext,$expensions)=== false){
         $errors[]="extension not allowed, please choose a JPEG or PNG file.";
      }

      if($file_size > 2097152) {
         $errors[]='File size must be excately 2 MB';
      }

      if(empty($errors)==true) {
         move_uploaded_file($file_tmp,"images/".$file_name);
         echo "Success";
      }else{
         print_r($errors);
      }
   }
?>
<html>
   <body>

      <form action = "" method = "POST" enctype = "multipart/form-data">
         <input type = "file" name = "image" />
         <input type = "submit"/>

         <ul>
            <li>Sent file: <?php echo $_FILES['image']['name'];  ?>
            <li>File size: <?php echo $_FILES['image']['size'];  ?>
            <li>File type: <?php echo $_FILES['image']['type'] ?>
         </ul>

      </form>

   </body>
</html>

Radu Radu · Accepted Answer · 2017-09-27 16:17:36Z

0

You have to use a temporal variable to save the explode result

$tmp      = explode('.',$_FILES['image']['name']);
$file_ext = strtolower(end($tmp));

The simple explication is that you have to pass a variable to the "end" function not a function that returns it.

answered Sep 27, 2017 at 16:17

Radu Radu

17717 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Shuhad zaman · Accepted Answer · 2018-09-23 08:14:24Z

0

Assign the result of explode to a variable and pass that variable to end, follow this example

$tmp = explode('.', $fileName);
$fileExtension = end($tmp);

You can also use following method to get extension

$fileExtension = pathinfo($fileName, PATHINFO_EXTENSION);

answered Sep 23, 2018 at 8:14

Shuhad zaman

2,90034 silver badges33 bronze badges

Collectives™ on Stack Overflow

Fix Error: Image Upload Script - Only variables should be passed by reference

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related