for loop not returning data when iterating through multiple values

Question

I have a function which its job its to delete a value selected by the user, it loops through an array of selected values and the data, when it iterates through both it checks if the selected value is equal to any property in the data, if it returns true, I get a new array of data.

When I select one value in the checkbox I do indeed see the correct data being returned, but when I select multiple my function does not work. I have being pondering all day, I will really appreciate any input.

HTML

<div class="ibox-content">
    <table class="table table-striped">
        <thead>
            <tr>
                <th>Select</th>
                <th class="col-xs-3">Issue Description</th>
                <th class="col-xs-3 text-center">Category</th>
                <th class="col-xs-3 text-center">Jira</th>
            </tr>
        </thead>
        <tbody>
            <tr ng-repeat="issue in wiq.data">
                <td><input type="checkbox" checklist-model="wiq.selections" checklist-value="issue.jira"> </td>
                <td>{{issue.issue}}</td>
                <td class="text-center">{{issue.description}}</td>
                <td class="text-center">{{issue.jira}}</td>
            </tr>

            <pre>{{wiq.selections}}</pre>
        </tbody>
    </table>
    <form>
        <button type="button" name="button" class="btn btn-success pull-right" style="margin-top:2em;" ng-click="wiq.acknowledge()">Acknowledge</button>
    </form>
</div>

Controller.js

ctrl.selections = []
ctrl.data = [
    {issue:"CMDY has issue", description:"issue",jira:"CDVR-173"},
    {issue:"SPK has issue", description:"issue",jira:"CDVR-125"}
]

ctrl.acknowledge = function() {
    var data = [];
    for (var i = 0; i < ctrl.data.length; i++) {
        for (var j = 0; j < ctrl.selections.length; j++) {
            if (ctrl.selections[j] != ctrl.data[i].jira) {
                data.push(ctrl.data[i]);
            }
        }
    }
    ctrl.data = data;
    console.log(ctrl.data)
};

This may be unrelated to your issue, but make sure you end your array assignments with semicolons. — Daniel W.
– Daniel W., Commented Oct 2, 2017 at 22:17

Renaud T. · Accepted Answer · 2017-10-02 21:52:35Z

1

When you have multiple selection, you loop multiple times, so you call "push" too many times.

try :

function filterData(somedata, selections) {
    return somedata.filter(item => (selections.findIndex(o => o === item.jira ) == -1));
};

then

ctrl.acknowledge = function() {
    ctrl.data = filterData(ctrl.data,ctrl.selections);
    console.log(ctrl.data)
};

answered Oct 2, 2017 at 21:52

Renaud T.

1392 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

pegla · Accepted Answer · 2017-10-02 21:55:00Z

0

Simple one liner will solve your problems, try this:

ctrl.acknowledge = function() {
    var data = ctrl.data.filter(val => ctrl.selections.indexOf(val.jira) === -1);
    ctrl.data = data;
    console.log(ctrl.data)
  };

Here's jsfiddle: http://jsfiddle.net/pegla/xj9gqqxn/7/

answered Oct 2, 2017 at 21:55

pegla

1,8864 gold badges19 silver badges20 bronze badges

Collectives™ on Stack Overflow

for loop not returning data when iterating through multiple values

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related