Resetting input properties in PHP class

Question

Developing further the class first referred to here.

My aim is to create a class where $inputNumber and $inputArray can be reset, but the methods below don't seem to work.

class myClass
{
public $inputNumber = 27;
public $inputArray = array(1, 2, 4);
public $outputArray = array();

public function setInput($newNumber)
{
    $this->inputNumber = $newNumber;
}

public function setArray($newArray)
{
    $this->inputArray = $newArray;
}

function __construct() {
   $this->outputArray= array($this->inputArray[0]*$this->inputNumber, 
                             $this->inputArray[1]*$this->inputNumber, 
                             $this->inputArray[2]*$this->inputNumber
                             );
}

public function printOutput()
{
    $output = "1st value is " . $this->outputArray[0] . "<br>";
    $output .= "2nd value is " . $this->outputArray[1] . "<br>";
    $output .= "3rd value is " . $this->outputArray[2] . "<br>";
    return $output;
}

}

$obj = new myClass;
$obj = setInput(54);
$obj = setArray(array(6, 12, 24);
echo $obj->printOutput();

scrowler · Accepted Answer · 2017-10-08 21:48:26Z

2

The problem is that outputArray is calculated in the construction of the class, which happens before you've set your input and array.

You should move the calculation logic to its own method, e.g.:

public function calculateOutput()
{
    $this->outputArray= array(
        $this->inputArray[0] * $this->inputNumber, 
        $this->inputArray[1] * $this->inputNumber, 
        $this->inputArray[2] * $this->inputNumber
    );
}

public function printOutput()
{
    // Calculate your result now
    $this->calculateOutput();

    $output = "1st value is " . $this->outputArray[0] . "<br>";
    $output .= "2nd value is " . $this->outputArray[1] . "<br>";
    $output .= "3rd value is " . $this->outputArray[2] . "<br>";
    return $output;
}

Then remove the constructor and your code should work as you have it already.

answered Oct 8, 2017 at 21:48

scrowler

24.4k10 gold badges67 silver badges99 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Resetting input properties in PHP class

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related