PHP if statement from mysql results

Question

I'm attempting to read results from a mysql db, determine when the result is a 1 or a 0 and then set a variable to either green.png or red.png:

$result = mysql_query("select * from ping limit 1") or die(mysql_error());
               $row = mysql_fetch_array($result);

                                $beckton = $row['beckton'];
                                if ($beckton = '1'){
                                    $beckton_status = "<img src='images/green.png' width='75px' height='75px' />";
                                }
                                else if ($beckton = '0'){
                                    $beckton_status = "<img src='images/red.png' width='75px' height='75px' />";
                                }

In my table 'ping' there is a column called 'beckton' which will be either a 1 or a 0. however when i load the page, all images are set to green.png, when i can clearly see in the DB that some are 0's.

i'm then just doing this: echo "<td>Beckton</td><td>" . $beckton_status . "</td>";

Jason Benson · Accepted Answer · 2011-01-12 15:42:02Z

8

if($beckton == '1')

Not

 if($beckton = '1')

At a cursory glance it seems to me you are setting the $beckton variable, not comparing it.

answered Jan 12, 2011 at 15:42

Jason Benson

3,3981 gold badge23 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

qJake · Accepted Answer · 2011-01-12 15:43:52Z

3

It's also worth mentioning (although @Jason Benson is 100% correct), that you don't have a loop in your code at all. The code you've written will only return the first result of the database, and nothing more. You'll probably need a while() loop to iterate over all the database results, if your table has more than one entry in it (which I think you mentioned).

answered Jan 12, 2011 at 15:43

qJake

17.2k17 gold badges88 silver badges138 bronze badges

2 Comments

benhowdle89 Over a year ago

your right but on this occasion i only ever want to retrieve the latest result

qJake Over a year ago

Then you should still add some sort of sort (perhaps ORDER BY id DESC, or something similar).

Jan Dragsbaek · Accepted Answer · 2011-01-12 15:52:06Z

1

In your comment, you write that you only need your latest result, in this case, you should use some kind of ORDER BY timestamp=latest in your SQL, to ensure you always get the latest result

answered Jan 12, 2011 at 15:52

Jan Dragsbaek

8,1212 gold badges28 silver badges46 bronze badges

Collectives™ on Stack Overflow

PHP if statement from mysql results

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related