Adding textbox values to an array not working C#

Question

I'm trying to add textbox and numericUpandDown values to an array, but it doesn't seem to be working.

Carro []carros = new Carro[1];
private Carro carro;

public Form1()
{
    ..
}

private void Form1_Load(object sender, EventArgs e)
{
    ..
}

private void AdicionarCarro()
{
    this.carro = new Carro(textboxCor.Text, textboxMarca.Text, textboxModelo.Text,
        (int.Parse(numUpDownCilindrada.Text)), (int.Parse(numUpDownVelocidade.Text)));
}

private Carro[] AdicionarArray(Carro carro, Carro[] array)
{
    AdicionarCarro();

    int novoTamanho = array.Length + 1;

    Carro[] carros = new Carro[novoTamanho];

    for (int i = 0; i < array.Length; i++)
    {
        carros[i] = array[i];
    }

    carros[novoTamanho] = carro;


    return carros;
}

private void buttonGravar_Click(object sender, EventArgs e)
{
    AdicionarArray(carro, carros);
}

When I type the values and click on the "buttonGravar", it gives me this Error:

I'd be much delighted to get some tips/help on it.

The array is defined to hold only one value, Carro []carros = new Carro[1]; that's why you are getting that error — sujith karivelil
– sujith karivelil, Commented Oct 13, 2017 at 12:47
Possible duplicate of What is an "index out of range" exception, and how do I fix it? — SᴇM
– SᴇM, Commented Oct 13, 2017 at 12:50
You are forgetting to use the return value of AdicionarArray(). It is just a fundamentally wrong way to do this, and not just because you forgot to update the carros variable, change its declaration to List<Carro> instead. — Hans Passant
– Hans Passant, Commented Oct 13, 2017 at 13:04

Ian H. · Accepted Answer · 2017-10-13 13:28:12Z

6

Using System.Collection.Generic.List<T> would be much simpler, since it doesn't have a fixed size:

List<Carro> carros = new List<Carro>();
carros.AddRange(array);
carros.Add(carro);
return carros;

edited Oct 13, 2017 at 13:28

Ian H.

3,9495 gold badges36 silver badges63 bronze badges

answered Oct 13, 2017 at 12:58

Joe

82.8k18 gold badges130 silver badges147 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

ckvywk Over a year ago

I'm still a student, and we still haven't been on that part yet (If I remember it correctly), thanks for the alternative solution though!

ckvywk Over a year ago

I used this, but it doesn't seem to be working, It says "Cannot implicitly convert type 'System.Collections.Generic.List<CriarCarroForm.Carro>' to 'CriarCarroForm.Carro[]' "

Yahya · Accepted Answer · 2017-10-13 13:02:56Z

3

Better way:

private List<Carro> Carros;

public Form1()
{
    Carros = new List<Carro>();
    ..
}

private void Form1_Load(object sender, EventArgs e)
{
    ..
}

private void AdicionarCarro()
{
    var carro = new Carro(textboxCor.Text, textboxMarca.Text, textboxModelo.Text,
        (int.Parse(numUpDownCilindrada.Text)), (int.Parse(numUpDownVelocidade.Text)));
    Carros.Add(carro);
}

private void buttonGravar_Click(object sender, EventArgs e)
{
    AdicionarCarro();
}

To help you understand your code:

carros[novoTamanho] = carro;

should be

carros[novoTamanho - 2] = carro;

Reason:

Array index starts from 0. novoTamanh represents new length (starting at 1, not 0 unlike index), which is outside array.

edited Oct 13, 2017 at 13:02

answered Oct 13, 2017 at 12:49

Yahya

3,4743 gold badges25 silver badges42 bronze badges

6 Comments

DonBoitnott Over a year ago

All of that acrobatic indexing is begging someone to point out just how horrible that code really is, and how it needs a complete overhaul, instead of more bandaids.

ckvywk Over a year ago

Oh yes! Thanks, that was so dumb of me to not to realize that!

ckvywk Over a year ago

@DonBoitnott Hey thanks for pointing it out:D, I'm really a beginner, even lower.

ckvywk Over a year ago

@DonBoitnott What do you mean by acrobatic indexing though?

DonBoitnott Over a year ago

Sorry to be so blunt, but I tend to suggest better fixes, not just how to dodge the problems one makes for themselves...beginner or no. As to your question...I mean if you find the need to do fancy indexing like is being suggested, it typically means you're abusing the array, or mishandling its overall usage.

|

Otman IGHOULASSEN · Accepted Answer · 2017-10-13 13:18:18Z

0

It's an index out of range exception because your array Carro is of size tmanho:

Carro[] carros = new Carro[novoTamanho];

and carros can contain exactly "novoTamanho" items indexed from "0" to "novoTamanho -1"

You can simply solve this by defining:

int novoTamanho = array.Length + 2;

Or if you do not want to manage indexes, use Lists:

List<Carro> listCarro = new List<Carro>;
listCarro.AddRAnge(array);
listCarro.Add(carro); 
return listCarro.ToArray();

answered Oct 13, 2017 at 13:18

Otman IGHOULASSEN

1232 silver badges9 bronze badges

Collectives™ on Stack Overflow

Adding textbox values to an array not working C#

3 Answers 3

2 Comments

6 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related